diff mbox series

dmaengine: idxd: set DMA channel to be private

Message ID 161074758743.2184057.3388557138816350980.stgit@djiang5-desk3.ch.intel.com (mailing list archive)
State Accepted
Headers show
Series dmaengine: idxd: set DMA channel to be private | expand

Commit Message

Dave Jiang Jan. 15, 2021, 9:53 p.m. UTC 
Add DMA_PRIVATE attribute flag to idxd DMA channels. The dedicated WQs are
expected to be used by a single client and not shared. While doing NTB
testing this mistake was discovered, which prevented ntb_transport from
requesting DSA wqs as DMA channels via dma_request_channel().

Reported-by: Srinijia Kambham <srinija.kambham@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Tested-by: Srinijia Kambham <srinija.kambham@intel.com>
Fixes: 8f47d1a5e545 ("dmaengine: idxd: connect idxd to dmaengine subsystem")
---
 drivers/dma/idxd/dma.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul Jan. 17, 2021, 6:52 a.m. UTC | #1 
On 15-01-21, 14:53, Dave Jiang wrote:
> Add DMA_PRIVATE attribute flag to idxd DMA channels. The dedicated WQs are
> expected to be used by a single client and not shared. While doing NTB
> testing this mistake was discovered, which prevented ntb_transport from
> requesting DSA wqs as DMA channels via dma_request_channel().

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
index 8ed2773d8285..90d19d06783a 100644
--- a/drivers/dma/idxd/dma.c
+++ b/drivers/dma/idxd/dma.c
@@ -165,6 +165,7 @@  int idxd_register_dma_device(struct idxd_device *idxd)
 	INIT_LIST_HEAD(&dma->channels);
 	dma->dev = &idxd->pdev->dev;
 
+	dma_cap_set(DMA_PRIVATE, dma->cap_mask);
 	dma_cap_set(DMA_COMPLETION_NO_ORDER, dma->cap_mask);
 	dma->device_release = idxd_dma_release;