| Message ID | 163a2cf11b2aceee2a1b8dc83251576d2371d4a6.1642383007.git.zong.li@sifive.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Determine the number of DMA channels by 'dma-channels' property | expand |
On 17/01/2022 01:35, Zong Li wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Add dma-channels property, then we can determine how many channels there > by device tree. > > Signed-off-by: Zong Li <zong.li@sifive.com> > --- > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 1 + > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > index c9f6d205d2ba..3c48f2d7a4a4 100644 > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > @@ -188,6 +188,7 @@ dma@3000000 { > reg = <0x0 0x3000000 0x0 0x8000>; > interrupt-parent = <&plic>; > interrupts = <23 24 25 26 27 28 29 30>; > + dma-channels = <4>; > #dma-cells = <1>; > }; For mpfs: Acked-by: Conor Dooley <conor.dooley@microchip.com> > > diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > index 0655b5c4201d..2bdfe7f06e4b 100644 > --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > @@ -171,6 +171,7 @@ dma: dma@3000000 { > reg = <0x0 0x3000000 0x0 0x8000>; > interrupt-parent = <&plic0>; > interrupts = <23 24 25 26 27 28 29 30>; > + dma-channels = <4>; > #dma-cells = <1>; > }; > uart1: serial@10011000 { > -- > 2.31.1 >
On Sun, 16 Jan 2022 17:35:26 PST (-0800), zong.li@sifive.com wrote: > Add dma-channels property, then we can determine how many channels there > by device tree. > > Signed-off-by: Zong Li <zong.li@sifive.com> > --- > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 1 + > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > index c9f6d205d2ba..3c48f2d7a4a4 100644 > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > @@ -188,6 +188,7 @@ dma@3000000 { > reg = <0x0 0x3000000 0x0 0x8000>; > interrupt-parent = <&plic>; > interrupts = <23 24 25 26 27 28 29 30>; > + dma-channels = <4>; > #dma-cells = <1>; > }; > > diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > index 0655b5c4201d..2bdfe7f06e4b 100644 > --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > @@ -171,6 +171,7 @@ dma: dma@3000000 { > reg = <0x0 0x3000000 0x0 0x8000>; > interrupt-parent = <&plic0>; > interrupts = <23 24 25 26 27 28 29 30>; > + dma-channels = <4>; > #dma-cells = <1>; > }; > uart1: serial@10011000 { I've got some comments in on the bindings, but I'm assuming it's easier to keep these all together. Happy to take this through the RISC-V tree, but I'm guessing it'll be easier to take these via dmaengine as there's a lot more diff there so Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> Thanks!
On 17-01-22, 09:35, Zong Li wrote: > Add dma-channels property, then we can determine how many channels there > by device tree. > > Signed-off-by: Zong Li <zong.li@sifive.com> > --- > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 1 + > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > index c9f6d205d2ba..3c48f2d7a4a4 100644 > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > @@ -188,6 +188,7 @@ dma@3000000 { Unrelated but the node name should be dma-controller@... > reg = <0x0 0x3000000 0x0 0x8000>; > interrupt-parent = <&plic>; > interrupts = <23 24 25 26 27 28 29 30>; > + dma-channels = <4>; > #dma-cells = <1>; > }; > > diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > index 0655b5c4201d..2bdfe7f06e4b 100644 > --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > @@ -171,6 +171,7 @@ dma: dma@3000000 { > reg = <0x0 0x3000000 0x0 0x8000>; > interrupt-parent = <&plic0>; > interrupts = <23 24 25 26 27 28 29 30>; > + dma-channels = <4>; > #dma-cells = <1>; > }; > uart1: serial@10011000 { > -- > 2.31.1
On Thu, Jan 27, 2022 at 3:03 PM Vinod Koul <vkoul@kernel.org> wrote: > > On 17-01-22, 09:35, Zong Li wrote: > > Add dma-channels property, then we can determine how many channels there > > by device tree. > > > > Signed-off-by: Zong Li <zong.li@sifive.com> > > --- > > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 1 + > > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > > index c9f6d205d2ba..3c48f2d7a4a4 100644 > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > > @@ -188,6 +188,7 @@ dma@3000000 { > > Unrelated but the node name should be dma-controller@... > Thanks for the correction, I guess we could give another patch for changing the node name. > > reg = <0x0 0x3000000 0x0 0x8000>; > > interrupt-parent = <&plic>; > > interrupts = <23 24 25 26 27 28 29 30>; > > + dma-channels = <4>; > > #dma-cells = <1>; > > }; > > > > diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > > index 0655b5c4201d..2bdfe7f06e4b 100644 > > --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > > +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi > > @@ -171,6 +171,7 @@ dma: dma@3000000 { > > reg = <0x0 0x3000000 0x0 0x8000>; > > interrupt-parent = <&plic0>; > > interrupts = <23 24 25 26 27 28 29 30>; > > + dma-channels = <4>; > > #dma-cells = <1>; > > }; > > uart1: serial@10011000 { > > -- > > 2.31.1 > > -- > ~Vinod
diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi index c9f6d205d2ba..3c48f2d7a4a4 100644 --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi @@ -188,6 +188,7 @@ dma@3000000 { reg = <0x0 0x3000000 0x0 0x8000>; interrupt-parent = <&plic>; interrupts = <23 24 25 26 27 28 29 30>; + dma-channels = <4>; #dma-cells = <1>; }; diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi index 0655b5c4201d..2bdfe7f06e4b 100644 --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi @@ -171,6 +171,7 @@ dma: dma@3000000 { reg = <0x0 0x3000000 0x0 0x8000>; interrupt-parent = <&plic0>; interrupts = <23 24 25 26 27 28 29 30>; + dma-channels = <4>; #dma-cells = <1>; }; uart1: serial@10011000 {
Add dma-channels property, then we can determine how many channels there by device tree. Signed-off-by: Zong Li <zong.li@sifive.com> --- arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 1 + arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 + 2 files changed, 2 insertions(+)