| Message ID | 20140113203404.GF27282@n2100.arm.linux.org.uk (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
* Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 12:36]: > On Mon, Jan 13, 2014 at 11:26:31AM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 10:57]: > > > On Mon, Jan 13, 2014 at 09:37:45AM -0800, Tony Lindgren wrote: > > > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 08:48]: > > > > > Any news on this? > > > > > > > > Sorry for the delay, now getting this: > > > > > > > > arch/arm/mach-omap1/dma.c: In function ‘omap1_system_dma_init’: > > > > arch/arm/mach-omap1/dma.c:368: error: ‘struct omap_dma_dev_attr’ has no member named ‘chan’ > > > > > > Gah. Next incremental patch: > > > > Thanks, now getting this on omap1: > > > > # dmesg | grep -i dma > > DMA: preallocated 256 KiB pool for atomic coherent allocations > > OMAP DMA hardware version 1 > > DMA capabilities: 0000000c:00000000:01ff:003f:007f > > omap-dma-engine omap-dma-engine: invalid resource > > omap-dma-engine: probe of omap-dma-engine failed with error -22 > > mmci-omap mmci-omap.1: unable to obtain TX DMA engine channel 54 > > mmci-omap mmci-omap.1: unable to obtain RX DMA engine channel 55 > > Sigh... let's give it the iomem resource then: OK, looks like adding that makes MMC card detection to fail with: DMA timeout with device 55 Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 13, 2014 at 01:02:42PM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 12:36]: > > On Mon, Jan 13, 2014 at 11:26:31AM -0800, Tony Lindgren wrote: > > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 10:57]: > > > > On Mon, Jan 13, 2014 at 09:37:45AM -0800, Tony Lindgren wrote: > > > > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 08:48]: > > > > > > Any news on this? > > > > > > > > > > Sorry for the delay, now getting this: > > > > > > > > > > arch/arm/mach-omap1/dma.c: In function ‘omap1_system_dma_init’: > > > > > arch/arm/mach-omap1/dma.c:368: error: ‘struct omap_dma_dev_attr’ has no member named ‘chan’ > > > > > > > > Gah. Next incremental patch: > > > > > > Thanks, now getting this on omap1: > > > > > > # dmesg | grep -i dma > > > DMA: preallocated 256 KiB pool for atomic coherent allocations > > > OMAP DMA hardware version 1 > > > DMA capabilities: 0000000c:00000000:01ff:003f:007f > > > omap-dma-engine omap-dma-engine: invalid resource > > > omap-dma-engine: probe of omap-dma-engine failed with error -22 > > > mmci-omap mmci-omap.1: unable to obtain TX DMA engine channel 54 > > > mmci-omap mmci-omap.1: unable to obtain RX DMA engine channel 55 > > > > Sigh... let's give it the iomem resource then: > > OK, looks like adding that makes MMC card detection to fail with: > > DMA timeout with device 55 You should also see a message: oma-dma-engine omap-dma-engine: failed to get L1 IRQ: .. which indicates that it's falling back to the old driver for IRQ servicing. Can you confirm that please?
* Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 13:13]: > On Mon, Jan 13, 2014 at 01:02:42PM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 12:36]: > > > On Mon, Jan 13, 2014 at 11:26:31AM -0800, Tony Lindgren wrote: > > > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 10:57]: > > > > > On Mon, Jan 13, 2014 at 09:37:45AM -0800, Tony Lindgren wrote: > > > > > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 08:48]: > > > > > > > Any news on this? > > > > > > > > > > > > Sorry for the delay, now getting this: > > > > > > > > > > > > arch/arm/mach-omap1/dma.c: In function ‘omap1_system_dma_init’: > > > > > > arch/arm/mach-omap1/dma.c:368: error: ‘struct omap_dma_dev_attr’ has no member named ‘chan’ > > > > > > > > > > Gah. Next incremental patch: > > > > > > > > Thanks, now getting this on omap1: > > > > > > > > # dmesg | grep -i dma > > > > DMA: preallocated 256 KiB pool for atomic coherent allocations > > > > OMAP DMA hardware version 1 > > > > DMA capabilities: 0000000c:00000000:01ff:003f:007f > > > > omap-dma-engine omap-dma-engine: invalid resource > > > > omap-dma-engine: probe of omap-dma-engine failed with error -22 > > > > mmci-omap mmci-omap.1: unable to obtain TX DMA engine channel 54 > > > > mmci-omap mmci-omap.1: unable to obtain RX DMA engine channel 55 > > > > > > Sigh... let's give it the iomem resource then: > > > > OK, looks like adding that makes MMC card detection to fail with: > > > > DMA timeout with device 55 > > You should also see a message: > > oma-dma-engine omap-dma-engine: failed to get L1 IRQ: .. > > which indicates that it's falling back to the old driver for IRQ > servicing. Can you confirm that please? Yes that's correct, here are all the DMA related lines: DMA: preallocated 256 KiB pool for atomic coherent allocations OMAP DMA hardware version 1 DMA capabilities: 0000000c:00000000:01ff:003f:007f omap-dma-engine omap-dma-engine: failed to get L1 IRQ: -6 omap-dma-engine omap-dma-engine: OMAP DMA engine driver omap-dma-engine omap-dma-engine: allocating channel 0 for 54 omap-dma-engine omap-dma-engine: allocating channel 1 for 55 DMA timeout with device 55 Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 13, 2014 at 01:21:18PM -0800, Tony Lindgren wrote: > Yes that's correct, here are all the DMA related lines: > > DMA: preallocated 256 KiB pool for atomic coherent allocations > OMAP DMA hardware version 1 > DMA capabilities: 0000000c:00000000:01ff:003f:007f > omap-dma-engine omap-dma-engine: failed to get L1 IRQ: -6 > omap-dma-engine omap-dma-engine: OMAP DMA engine driver > omap-dma-engine omap-dma-engine: allocating channel 0 for 54 > omap-dma-engine omap-dma-engine: allocating channel 1 for 55 > DMA timeout with device 55 Hmm, that's annoying, and will be annoying to debug remotely. Would you like a new set of patches to try bisecting to find the culpret?
* Russell King - ARM Linux <linux@arm.linux.org.uk> [140113 13:30]: > On Mon, Jan 13, 2014 at 01:21:18PM -0800, Tony Lindgren wrote: > > Yes that's correct, here are all the DMA related lines: > > > > DMA: preallocated 256 KiB pool for atomic coherent allocations > > OMAP DMA hardware version 1 > > DMA capabilities: 0000000c:00000000:01ff:003f:007f > > omap-dma-engine omap-dma-engine: failed to get L1 IRQ: -6 > > omap-dma-engine omap-dma-engine: OMAP DMA engine driver > > omap-dma-engine omap-dma-engine: allocating channel 0 for 54 > > omap-dma-engine omap-dma-engine: allocating channel 1 for 55 > > DMA timeout with device 55 > > Hmm, that's annoying, and will be annoying to debug remotely. Would > you like a new set of patches to try bisecting to find the culpret? Sure that would help. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c index 1b1b64647def..4be601b638d7 100644 --- a/arch/arm/mach-omap1/dma.c +++ b/arch/arm/mach-omap1/dma.c @@ -261,6 +261,8 @@ static const struct platform_device_info omap_dma_dev_info = { .name = "omap-dma-engine", .id = -1, .dma_mask = DMA_BIT_MASK(32), + .res = res, + .num_res = 1, }; static struct omap_system_dma_plat_info dma_plat_info __initdata = {