| Message ID | 20150817190316.206318.88429.stgit@djiang5-desk3.ch.intel.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Mon, Aug 17, 2015 at 12:03:16PM -0700, Dave Jiang wrote: > The 32bit build is creating this warning. Since we don't expect anyone > actually use this on 32bit, restrict ioatdma to be built only on x86_64. > This issue has long existed and only reason it's surfacing due to code > refactoring. > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git for-linus > head: 638cf4f7510d6af6932dadf2844817f609b3cf3f > commit: 3372de5813e4da8305002ff6ffbfc0c7012cb319 [27/35] dmaengine: ioatdma: removal of dma_v3.c and relevant ioat3 references > config: i386-randconfig-i0-201533 (attached as .config) > reproduce: > git checkout 3372de5813e4da8305002ff6ffbfc0c7012cb319 > # save the attached .config to linux build tree > make ARCH=i386 > > All warnings (new ones prefixed by >>): I dont this above is required > > drivers/dma/ioat/dma.c: In function 'ioat_timer_event': > >> drivers/dma/ioat/dma.c:870:39: warning: passing argument 2 of 'ioat_cleanup_preamble' from incompatible pointer type > if (ioat_cleanup_preamble(ioat_chan, &phys_complete)) > ^ > drivers/dma/ioat/dma.c:577:13: note: expected 'u64 *' but argument is of type 'dma_addr_t *' > static bool ioat_cleanup_preamble(struct ioatdma_chan *ioat_chan, This alone should suffice and subject should say which warning you fixed And lastly, Sorry I cant apply these as these are missing S-O-B!!!
> -----Original Message----- > From: dmaengine-owner@vger.kernel.org [mailto:dmaengine-owner@vger.kernel.org] On Behalf Of Vinod Koul > Sent: Tuesday, August 18, 2015 9:38 AM > To: Jiang, Dave > Cc: dmaengine@vger.kernel.org; Williams, Dan J > Subject: Re: [PATCH 1/2] dmaengine: ioatdma: fix zero day warning on incompatible pointer type > > On Mon, Aug 17, 2015 at 12:03:16PM -0700, Dave Jiang wrote: > > The 32bit build is creating this warning. Since we don't expect anyone > > actually use this on 32bit, restrict ioatdma to be built only on x86_64. > > This issue has long existed and only reason it's surfacing due to code > > refactoring. > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git for-linus > > head: 638cf4f7510d6af6932dadf2844817f609b3cf3f > > commit: 3372de5813e4da8305002ff6ffbfc0c7012cb319 [27/35] dmaengine: ioatdma: removal of dma_v3.c and relevant ioat3 > references > > config: i386-randconfig-i0-201533 (attached as .config) > > reproduce: > > git checkout 3372de5813e4da8305002ff6ffbfc0c7012cb319 > > # save the attached .config to linux build tree > > make ARCH=i386 > > > > All warnings (new ones prefixed by >>): > I dont this above is required > > > > drivers/dma/ioat/dma.c: In function 'ioat_timer_event': > > >> drivers/dma/ioat/dma.c:870:39: warning: passing argument 2 of 'ioat_cleanup_preamble' from incompatible pointer type > > if (ioat_cleanup_preamble(ioat_chan, &phys_complete)) > > ^ > > drivers/dma/ioat/dma.c:577:13: note: expected 'u64 *' but argument is of type 'dma_addr_t *' > > static bool ioat_cleanup_preamble(struct ioatdma_chan *ioat_chan, > > This alone should suffice and subject should say which warning you fixed > > And lastly, Sorry I cant apply these as these are missing S-O-B!!! Doh! Sorry. I don't know how I missed that. > > -- > ~Vinod > > ^ > > --- > > drivers/dma/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > > index 88d474b..e5e2ada 100644 > > --- a/drivers/dma/Kconfig > > +++ b/drivers/dma/Kconfig > > @@ -65,7 +65,7 @@ config AMBA_PL08X > > > > config INTEL_IOATDMA > > tristate "Intel I/OAT DMA support" > > - depends on PCI && X86 > > + depends on PCI && X86_64 > > select DMA_ENGINE > > select DMA_ENGINE_RAID > > select DCA > > > > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 88d474b..e5e2ada 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -65,7 +65,7 @@ config AMBA_PL08X config INTEL_IOATDMA tristate "Intel I/OAT DMA support" - depends on PCI && X86 + depends on PCI && X86_64 select DMA_ENGINE select DMA_ENGINE_RAID select DCA
The 32bit build is creating this warning. Since we don't expect anyone actually use this on 32bit, restrict ioatdma to be built only on x86_64. This issue has long existed and only reason it's surfacing due to code refactoring. tree: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git for-linus head: 638cf4f7510d6af6932dadf2844817f609b3cf3f commit: 3372de5813e4da8305002ff6ffbfc0c7012cb319 [27/35] dmaengine: ioatdma: removal of dma_v3.c and relevant ioat3 references config: i386-randconfig-i0-201533 (attached as .config) reproduce: git checkout 3372de5813e4da8305002ff6ffbfc0c7012cb319 # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/dma/ioat/dma.c: In function 'ioat_timer_event': >> drivers/dma/ioat/dma.c:870:39: warning: passing argument 2 of 'ioat_cleanup_preamble' from incompatible pointer type if (ioat_cleanup_preamble(ioat_chan, &phys_complete)) ^ drivers/dma/ioat/dma.c:577:13: note: expected 'u64 *' but argument is of type 'dma_addr_t *' static bool ioat_cleanup_preamble(struct ioatdma_chan *ioat_chan, ^ --- drivers/dma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html