diff mbox

[v2,1/2] dmaengine: ioatdma: fix zero day warning on incompatible pointer type

Message ID 20150820154409.232123.16852.stgit@djiang5-desk3.ch.intel.com (mailing list archive)
State Accepted
Headers show

Commit Message

Dave Jiang Aug. 20, 2015, 3:44 p.m. UTC 
The 32bit build is creating this warning. Since we don't expect anyone
actually use this on 32bit, restrict ioatdma to be built only on x86_64.
This issue has long existed and only reason it's surfacing due to code
refactoring.

   drivers/dma/ioat/dma.c: In function 'ioat_timer_event':
>> drivers/dma/ioat/dma.c:870:39: warning: passing argument 2 of 'ioat_cleanup_preamble' from incompatible pointer type
     if (ioat_cleanup_preamble(ioat_chan, &phys_complete))
                                          ^
   drivers/dma/ioat/dma.c:577:13: note: expected 'u64 *' but argument is of type 'dma_addr_t *'
    static bool ioat_cleanup_preamble(struct ioatdma_chan *ioat_chan,
                ^

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Vinod Koul Aug. 21, 2015, 8:37 a.m. UTC | #1 
On Thu, Aug 20, 2015 at 08:44:09AM -0700, Dave Jiang wrote:
> The 32bit build is creating this warning. Since we don't expect anyone
> actually use this on 32bit, restrict ioatdma to be built only on x86_64.
> This issue has long existed and only reason it's surfacing due to code
> refactoring.
> 
>    drivers/dma/ioat/dma.c: In function 'ioat_timer_event':
> >> drivers/dma/ioat/dma.c:870:39: warning: passing argument 2 of 'ioat_cleanup_preamble' from incompatible pointer type
>      if (ioat_cleanup_preamble(ioat_chan, &phys_complete))
>                                           ^
>    drivers/dma/ioat/dma.c:577:13: note: expected 'u64 *' but argument is of type 'dma_addr_t *'
>     static bool ioat_cleanup_preamble(struct ioatdma_chan *ioat_chan,
>                 ^

Applied, both

Thanks
diff mbox

Patch

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 88d474b..e5e2ada 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -65,7 +65,7 @@  config AMBA_PL08X
 
 config INTEL_IOATDMA
 	tristate "Intel I/OAT DMA support"
-	depends on PCI && X86
+	depends on PCI && X86_64
 	select DMA_ENGINE
 	select DMA_ENGINE_RAID
 	select DCA