@@ -26,6 +26,8 @@
#include "hw.h"
#include "dma.h"
+#define MAX_SCF 1024
+
/* provide a lookup table for setting the source address in the base or
* extended descriptor of an xor or pq descriptor
*/
@@ -634,9 +636,12 @@ struct dma_async_tx_descriptor *
ioat_prep_pqxor(struct dma_chan *chan, dma_addr_t dst, dma_addr_t *src,
unsigned int src_cnt, size_t len, unsigned long flags)
{
- unsigned char scf[src_cnt];
+ unsigned char scf[MAX_SCF];
dma_addr_t pq[2];
+ if (src_cnt > MAX_SCF)
+ return NULL;
+
memset(scf, 0, src_cnt);
pq[0] = dst;
flags |= DMA_PREP_PQ_DISABLE_Q;
@@ -654,9 +659,12 @@ ioat_prep_pqxor_val(struct dma_chan *chan, dma_addr_t *src,
unsigned int src_cnt, size_t len,
enum sum_check_flags *result, unsigned long flags)
{
- unsigned char scf[src_cnt];
+ unsigned char scf[MAX_SCF];
dma_addr_t pq[2];
+ if (src_cnt > MAX_SCF)
+ return NULL;
+
/* the cleanup routine only sets bits on validate failure, it
* does not clear bits on validate success... so clear it here
*/
Sparse reported: drivers/dma/ioat/prep.c:637:27: sparse: Variable length array is used. Assigning a static value for the array. Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- drivers/dma/ioat/prep.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html