diff mbox

[1/2] k3dma: off by one in k3_of_dma_simple_xlate()

Message ID 20161012060029.GA12841@mwanda (mailing list archive)
State Not Applicable
Headers show

Commit Message

Dan Carpenter Oct. 12, 2016, 6 a.m. UTC 
The ->chans[] array has ->dma_requests elements so the check should be
>= instead of >.  The ->chans[] array is allocated in k3_dma_probe()

Fixes: 8e6152bc660e ('dmaengine: Add hisilicon k3 DMA engine driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
index 7c636c53..f17a8c0 100644
--- a/drivers/dma/k3dma.c
+++ b/drivers/dma/k3dma.c
@@ -792,7 +792,7 @@  static struct dma_chan *k3_of_dma_simple_xlate(struct of_phandle_args *dma_spec,
 	struct k3_dma_dev *d = ofdma->of_dma_data;
 	unsigned int request = dma_spec->args[0];
 
-	if (request > d->dma_requests)
+	if (request >= d->dma_requests)
 		return NULL;
 
 	return dma_get_slave_channel(&(d->chans[request].vc.chan));