diff mbox

[v2,2/5] usb: musb: Use shared irq

Message ID 20170117143528.11404-3-abailon@baylibre.com (mailing list archive)
State Superseded
Headers show

Commit Message

Alexandre Bailon Jan. 17, 2017, 2:35 p.m. UTC
In the DA8xx, USB and CPPI 4.1 are sharing the same interrupt line.
Update the driver to request a shared irq.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
---
 drivers/usb/musb/musb_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergei Shtylyov Jan. 17, 2017, 5:29 p.m. UTC | #1
On 01/17/2017 05:35 PM, Alexandre Bailon wrote:

> In the DA8xx, USB and CPPI 4.1 are sharing the same interrupt line.
> Update the driver to request a shared irq.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>

    I have noticed that you sent this to the dmaengine list
but not to linux-usb. Was that intentional?

MNR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexandre Bailon Jan. 17, 2017, 5:37 p.m. UTC | #2
On 01/17/2017 06:29 PM, Sergei Shtylyov wrote:
> On 01/17/2017 05:35 PM, Alexandre Bailon wrote:
> 
>> In the DA8xx, USB and CPPI 4.1 are sharing the same interrupt line.
>> Update the driver to request a shared irq.
>>
>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> 
>    I have noticed that you sent this to the dmaengine list
> but not to linux-usb. Was that intentional?
No, I have forgotten to add linux-usb ...
> 
> MNR, Sergei
> 

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index fca288bb..cf40adf 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2329,7 +2329,7 @@  musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
 	setup_timer(&musb->otg_timer, musb_otg_timer_func, (unsigned long) musb);
 
 	/* attach to the IRQ */
-	if (request_irq(nIrq, musb->isr, 0, dev_name(dev), musb)) {
+	if (request_irq(nIrq, musb->isr, IRQF_SHARED, dev_name(dev), musb)) {
 		dev_err(dev, "request_irq %d failed!\n", nIrq);
 		status = -ENODEV;
 		goto fail3;