From patchwork Sun Apr 2 14:50:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 9658517 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 253AC602F0 for ; Sun, 2 Apr 2017 14:50:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11FC52842B for ; Sun, 2 Apr 2017 14:50:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05FDA2845E; Sun, 2 Apr 2017 14:50:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 994D32842B for ; Sun, 2 Apr 2017 14:50:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751547AbdDBOuw (ORCPT ); Sun, 2 Apr 2017 10:50:52 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:36860 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbdDBOuv (ORCPT ); Sun, 2 Apr 2017 10:50:51 -0400 Received: by mail-lf0-f47.google.com with SMTP id x137so61317163lff.3 for ; Sun, 02 Apr 2017 07:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=xgPwm9Tddmu/qXyrIWjl3dbP+IbBSr9tIOLn1JrAoCI=; b=aOoTxO8O8TX+B5H+1Atw8NLy+6aAZTGbCuIyhgOf9+ODdY3gMaATXtFkTZICfYtWDq qMNajGGKEtLECo9ExqBZUgno/4tam0E+8Yf0mMNoX4dNSQA6e7WaK44izX/zaUZtPbUk IEQ+geO7MXtya6v5Glk9P5sUmKA6TcO/2ofv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xgPwm9Tddmu/qXyrIWjl3dbP+IbBSr9tIOLn1JrAoCI=; b=Z9SGXWpsgUyObKtOT/Ro3cWeD+IwaZr8v5IUN14C973RL1vbK8mGTkn+dTxiGHrElX x9swp8bqrgeGS/ZPSc4VxTUAiOcrjo+emoXhtOx2y1brCaYwnxAr8JYgfmuUSEt9pegY zb4gj7iSbld0E/sqSpwa0Wg53TJtJvUooHpt0ek/bsIocVqvQSdWR4b77MXAw2VavGK3 +fH2CPnvYH9An3dEYgm9HLUDqTn/MGZA/8ZKK1irOEzEi+3TLN9x8dSlXqvBLadZAQiK hQobREnDjSi2k/4XJncYJz8xbY/MOEGg5dKeTux0j1Yj6t6IIAa/JUKXFA8O9ZFtOafM higQ== X-Gm-Message-State: AFeK/H2F30JtFHWEfUJggS7hXW76H+xhmHM6Z6AN/vdXZyB3hNMKWIyLUEcRKNSwF9WMjfl1 X-Received: by 10.25.25.147 with SMTP id 141mr3873797lfz.87.1491144650100; Sun, 02 Apr 2017 07:50:50 -0700 (PDT) Received: from localhost.localdomain (c-357171d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.113.53]) by smtp.gmail.com with ESMTPSA id b17sm2023664lje.13.2017.04.02.07.50.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Apr 2017 07:50:48 -0700 (PDT) From: Linus Walleij To: Vinod Koul , dmaengine@vger.kernel.org Cc: Linus Walleij Subject: [PATCH 2/3] dma: pl080: Fix some missing kerneldoc Date: Sun, 2 Apr 2017 16:50:44 +0200 Message-Id: <20170402145044.24703-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.9.3 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Two elements of the physical channel description was missing. Signed-off-by: Linus Walleij --- drivers/dma/amba-pl08x.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 0b7c6ce629a6..8624598530f3 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -106,6 +106,7 @@ struct pl08x_driver_data; /** * struct vendor_data - vendor-specific config parameters for PL08x derivatives + * @config_offset: offset to the configuration register * @channels: the number of channels available in this variant * @signals: the number of request signals available from the hardware * @dualmaster: whether this version supports dual AHB masters or not. @@ -145,6 +146,8 @@ struct pl08x_bus_data { /** * struct pl08x_phy_chan - holder for the physical channels * @id: physical index to this channel + * @base: memory base address for this physical channel + * @reg_config: configuration address for this physical channel * @lock: a lock to use when altering an instance of this struct * @serving: the virtual channel currently being served by this physical * channel @@ -226,7 +229,7 @@ enum pl08x_dma_chan_state { * @phychan: the physical channel utilized by this channel, if there is one * @name: name of channel * @cd: channel platform data - * @runtime_addr: address for RX/TX according to the runtime config + * @cfg: slave configuration * @at: active transaction on this channel * @lock: a lock for this channel data * @host: a pointer to the host (internal use) @@ -262,7 +265,7 @@ struct pl08x_dma_chan { * @lli_buses: bitmask to or in to LLI pointer selecting AHB port for LLI * fetches * @mem_buses: set to indicate memory transfers on AHB2. - * @lock: a spinlock for this struct + * @lli_words: how many words are used in each LLI item for this variant */ struct pl08x_driver_data { struct dma_device slave;