From patchwork Fri Jun 30 07:34:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 9818629 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4688D60224 for ; Fri, 30 Jun 2017 07:58:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CE0F28066 for ; Fri, 30 Jun 2017 07:58:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31589285CB; Fri, 30 Jun 2017 07:58:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B065128066 for ; Fri, 30 Jun 2017 07:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751723AbdF3H6I (ORCPT ); Fri, 30 Jun 2017 03:58:08 -0400 Received: from gateway24.websitewelcome.com ([192.185.51.35]:13272 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbdF3H6H (ORCPT ); Fri, 30 Jun 2017 03:58:07 -0400 X-Greylist: delayed 1441 seconds by postgrey-1.27 at vger.kernel.org; Fri, 30 Jun 2017 03:58:07 EDT Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id DFAE85B86 for ; Fri, 30 Jun 2017 02:34:03 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id QqREdWJCIZqNPQqREd6Guk; Fri, 30 Jun 2017 02:34:00 -0500 Received: from [189.152.189.231] (port=48606 helo=embeddedgus) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1dQqRH-0030ia-Mj; Fri, 30 Jun 2017 02:34:03 -0500 Date: Fri, 30 Jun 2017 02:34:03 -0500 From: "Gustavo A. R. Silva" To: Vinod Koul , Dan Williams Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] dmaengine: idma64: print error message on platform_get_irq failure Message-ID: <20170630073403.GA24756@embeddedgus> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.189.231 X-Exim-ID: 1dQqRH-0030ia-Mj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.189.231]:48606 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 24 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- drivers/dma/idma64.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c index 1953e57..08ade66 100644 --- a/drivers/dma/idma64.c +++ b/drivers/dma/idma64.c @@ -637,8 +637,10 @@ static int idma64_platform_probe(struct platform_device *pdev) return -ENOMEM; chip->irq = platform_get_irq(pdev, 0); - if (chip->irq < 0) + if (chip->irq < 0) { + dev_err(dev, "failed to get IRQ: %d\n", chip->irq); return chip->irq; + } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); chip->regs = devm_ioremap_resource(dev, mem);