From patchwork Fri Jun 30 07:42:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 9818661 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3131D603D7 for ; Fri, 30 Jun 2017 08:03:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26A4E1FE84 for ; Fri, 30 Jun 2017 08:03:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B572285F1; Fri, 30 Jun 2017 08:03:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B2551FE84 for ; Fri, 30 Jun 2017 08:03:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751637AbdF3IDo (ORCPT ); Fri, 30 Jun 2017 04:03:44 -0400 Received: from gateway30.websitewelcome.com ([192.185.197.25]:27247 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbdF3IDl (ORCPT ); Fri, 30 Jun 2017 04:03:41 -0400 X-Greylist: delayed 1251 seconds by postgrey-1.27 at vger.kernel.org; Fri, 30 Jun 2017 04:03:41 EDT Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 23FC986DEB for ; Fri, 30 Jun 2017 02:42:48 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id QqZgdWTIJZqNPQqZgd6Qwm; Fri, 30 Jun 2017 02:42:44 -0500 Received: from [189.152.189.231] (port=48646 helo=embeddedgus) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1dQqZj-0037eF-TG; Fri, 30 Jun 2017 02:42:47 -0500 Date: Fri, 30 Jun 2017 02:42:47 -0500 From: "Gustavo A. R. Silva" To: Vinod Koul , Dan Williams , Michal Simek , =?iso-8859-1?Q?S=F6ren?= Brinkmann Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe() Message-ID: <20170630074247.GA26153@embeddedgus> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.189.231 X-Exim-ID: 1dQqZj-0037eF-TG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.189.231]:48646 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 30 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Print error message and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Sören Brinkmann --- drivers/dma/xilinx/zynqmp_dma.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 6d221e5..5fa6d0d 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -996,8 +996,11 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, zynqmp_dma_init(chan); chan->irq = platform_get_irq(pdev, 0); - if (chan->irq < 0) - return -ENXIO; + if (chan->irq < 0) { + dev_err(&pdev->dev, "failed to get IRQ: %d\n", chan->irq); + return chan->irq; + } + err = devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0, "zynqmp-dma", chan); if (err)