From patchwork Tue Aug 1 20:09:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Borneo X-Patchwork-Id: 9875431 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E85886041F for ; Tue, 1 Aug 2017 20:10:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB68528746 for ; Tue, 1 Aug 2017 20:10:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D05662874A; Tue, 1 Aug 2017 20:10:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C06C28746 for ; Tue, 1 Aug 2017 20:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752432AbdHAUKI (ORCPT ); Tue, 1 Aug 2017 16:10:08 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36531 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbdHAUKF (ORCPT ); Tue, 1 Aug 2017 16:10:05 -0400 Received: by mail-wr0-f194.google.com with SMTP id y67so2221922wrb.3; Tue, 01 Aug 2017 13:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=KLRu2V7/3Aqtw/brjjf+jow8smBhCY0Em8cD+5hAwrg=; b=cTWLHirlnrfV+o52InewjbpDFPsHTVOOp7rWUw/RSfznGZRMdNgwZ8Ijpv8LOtL5Ue RnmLPJHtADbWUcbAsafHvn9xkciZeaPl3l2yiTD1Zvvf1kaH989PwSdoa4O8zjshTyDQ wCwiYrZDohYJvDr8NgudnnqhlBfKVZ686g6nKtJD/DTOMr+ltHUQqR62Dcy45xePZQeY qqG3c5XDqv5Fg5zCuxlBiyKJIjvsyEa1BzkwTQ09AFyNPCCFQXsTkqUQc3tFsBt5Iny5 Xx3shRzg/0FuycsGyIuplfP6MY3KWHMlPpeSDUVthLKYG6fKD5Oa+77CAmxhk/+07F+U hDPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=KLRu2V7/3Aqtw/brjjf+jow8smBhCY0Em8cD+5hAwrg=; b=nMqjPXIOir88lZ1WwUzL56Em/8naIlsQVpEABgaFvFnaMAytwBbIXdqRG/jOs2C/8w Wv8b83m/k19fyUp4d4M4y+67gHPmn/coFFK/7fctgHGar5qG6yCWiE/YblUe4waDZuNQ r6gpxHTntsr11US/l191PSePVjvzKq74dBLmRBxjp1LxFTBx1pyQ78as/juhFGY8mqD2 0binosglFoSQK1+RsGgX9t7HmF4OZg5wRYNjENc7KFezFtZNwvASR5vgi42FG+OSzLTk jm32GHkh8hiw/ImBXsrs5piPLxNaCgiYRATpuyIdEC3xvOnfr6A1vv9KmueG71Ys1U7X jx+w== X-Gm-Message-State: AIVw113w7t6uV26MQ28+pSk1KVRDeuoDrWurHiOJbxpYtU8WvO7ijo1a DjQpoAsQj1xHZV4A4Gk= X-Received: by 10.223.139.21 with SMTP id n21mr18183192wra.116.1501618204153; Tue, 01 Aug 2017 13:10:04 -0700 (PDT) Received: from localhost.localdomain ([2a01:e34:edb8:72e0:f7c2:bbb1:de32:ba2a]) by smtp.gmail.com with ESMTPSA id i7sm29722581wrb.19.2017.08.01.13.10.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 13:10:03 -0700 (PDT) From: Antonio Borneo To: dmaengine@vger.kernel.org, Vinod Koul , Dan Williams Cc: Antonio Borneo , linux-kernel@vger.kernel.org, John Stultz , Zhangfei Gao Subject: [PATCH v2 3/3] dmaengine: k3dma: remove useless ON_WARN_ONCE() Date: Tue, 1 Aug 2017 22:09:27 +0200 Message-Id: <20170801200928.24661-4-borneo.antonio@gmail.com> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170801200928.24661-1-borneo.antonio@gmail.com> References: <20170801200928.24661-1-borneo.antonio@gmail.com> In-Reply-To: References: Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 36387a2b1f62b5c087c5fe6f0f7b23b94f722ad7 ("k3dma: Fix memory handling in preparation for cyclic mode") adds few calls to ON_WARN_ONCE() to track the use of ds_run/ds_done. After the two fixes: - dmaengine: k3dma: fix non-cyclic mode - dmaengine: k3dma: fix re-free of the same descriptor the behaviour of ds_run/ds_done is properly fixed. The remaining ON_WARN_ONCE() are never triggered and can be removed. Signed-off-by: Antonio Borneo --- To: dmaengine@vger.kernel.org To: Vinod Koul To: Dan Williams Cc: linux-kernel@vger.kernel.org Cc: John Stultz Cc: Zhangfei Gao --- drivers/dma/k3dma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c index b769623..01d2a75 100644 --- a/drivers/dma/k3dma.c +++ b/drivers/dma/k3dma.c @@ -223,7 +223,6 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id) if (c && (tc1 & BIT(i))) { spin_lock_irqsave(&c->vc.lock, flags); vchan_cookie_complete(&p->ds_run->vd); - WARN_ON_ONCE(p->ds_done); p->ds_done = p->ds_run; p->ds_run = NULL; spin_unlock_irqrestore(&c->vc.lock, flags); @@ -274,7 +273,6 @@ static int k3_dma_start_txd(struct k3_dma_chan *c) */ list_del(&ds->vd.node); - WARN_ON_ONCE(c->phy->ds_run); c->phy->ds_run = ds; c->phy->ds_done = NULL; /* start dma */