| Message ID | 20180201202012.36524-5-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu, 2018-02-01 at 22:20 +0200, Andy Shevchenko wrote: > The value under the hood is constant in any case. > It makes sense to show this explicitly. > This patch is wrong, sorry. > Fixes: 95fbfb7aa28d ("dmaengine: qcom_hidma: Add support for the new > revision") > Cc: Sinan Kaya <okaya@codeaurora.org> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Vinod Koul <vinod.koul@intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/dma/qcom/hidma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c > index 963cc5228d05..24e163cefb7c 100644 > --- a/drivers/dma/qcom/hidma.c > +++ b/drivers/dma/qcom/hidma.c > @@ -743,9 +743,9 @@ static int hidma_request_msi(struct hidma_dev > *dmadev, > > static bool hidma_test_capability(struct device *dev, enum hidma_cap > test_cap) > { > - enum hidma_cap cap; > + const enum hidma_cap cap; > > - cap = (enum hidma_cap) device_get_match_data(dev); > + cap = (const enum hidma_cap) device_get_match_data(dev); > return cap ? ((cap & test_cap) > 0) : 0; > } >
diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 963cc5228d05..24e163cefb7c 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -743,9 +743,9 @@ static int hidma_request_msi(struct hidma_dev *dmadev, static bool hidma_test_capability(struct device *dev, enum hidma_cap test_cap) { - enum hidma_cap cap; + const enum hidma_cap cap; - cap = (enum hidma_cap) device_get_match_data(dev); + cap = (const enum hidma_cap) device_get_match_data(dev); return cap ? ((cap & test_cap) > 0) : 0; }
The value under the hood is constant in any case. It makes sense to show this explicitly. Fixes: 95fbfb7aa28d ("dmaengine: qcom_hidma: Add support for the new revision") Cc: Sinan Kaya <okaya@codeaurora.org> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Vinod Koul <vinod.koul@intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/dma/qcom/hidma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)