From patchwork Thu Apr 26 16:12:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moritz Fischer X-Patchwork-Id: 10366267 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1946760542 for ; Thu, 26 Apr 2018 16:18:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0CB6229102 for ; Thu, 26 Apr 2018 16:18:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0130229124; Thu, 26 Apr 2018 16:18:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB39E29102 for ; Thu, 26 Apr 2018 16:18:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756727AbeDZQSj (ORCPT ); Thu, 26 Apr 2018 12:18:39 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:40177 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756699AbeDZQSh (ORCPT ); Thu, 26 Apr 2018 12:18:37 -0400 Received: by mail-pg0-f68.google.com with SMTP id l2so2961855pgc.7 for ; Thu, 26 Apr 2018 09:18:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6Givt1fudCz5R+R5YUlOQaQdD4DALvn0Hh0MS10AH+M=; b=CCZgvvkzg/ZO29QaydBLHsoFzFehuvEmXpvNTrkwJTWpAcUdz2DMrphO3GbhvHwG69 +8vBsG2/N1mVvOTMkw0xnuttDN4WAJm/BHaPK+rKRaej3Jz841G+agYXuCBegoWH/ww1 Dh7biTVbFh+EcUSieLh91L6BDizLrjQmIBgxyFGw0CMI6GFcEC/2q6VoItaTGxjGq1K9 I/YW2zmAIYmQEIZ0NXf2/7CLV5cTn96Kkd7CWReP/t87SMHWfyVWJU6F1fzQ+7i8GHUy 8RZTeBctBi7+z7lTWC7Y8I94dFaqs8blrE+DS5Xp1UsAn3aiSOBOam5i5dBS5ERMa6Lz blkg== X-Gm-Message-State: ALQs6tAQwLOFao4eQqCxGrXkLoco02S1F5RMlQyyzpyqHDUNU+X18l9o o9w50AmS2grmXNX21mMUxN1a8fAd8Qc= X-Google-Smtp-Source: AIpwx48M8MdSPpHjnToSSHcrIPnx9Yz3vmOp6mNm5fUlob7atlToakLqt/g5z5Xz13Wqm4nQhjAHkQ== X-Received: by 10.99.106.4 with SMTP id f4mr27506761pgc.225.1524759516678; Thu, 26 Apr 2018 09:18:36 -0700 (PDT) Received: from localhost ([207.114.172.147]) by smtp.gmail.com with ESMTPSA id 199sm35659737pfy.51.2018.04.26.09.18.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 09:18:35 -0700 (PDT) From: Moritz Fischer To: linux-kernel@vger.kernel.org Cc: dmaengine@vger.kernel.org, vinod.koul@intel.com, dan.j.williams@intel.com, lars@metafoo.de, Moritz Fischer Subject: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Date: Thu, 26 Apr 2018 09:12:38 -0700 Message-Id: <20180426161239.15234-1-mdf@kernel.org> X-Mailer: git-send-email 2.17.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use devm_request_irq() instead of request_irq() to request the IRQ. Signed-off-by: Moritz Fischer --- Hi Lars, was there a specific reason not to use devm_request_irq() ? Cheers, Moritz --- drivers/dma/dma-axi-dmac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 2419fe524daa..75ccedaa96d2 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -687,8 +687,9 @@ static int axi_dmac_probe(struct platform_device *pdev) if (ret) goto err_unregister_device; - ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0, - dev_name(&pdev->dev), dmac); + ret = devm_request_irq(&pdev->dev, dmac->irq, + axi_dmac_interrupt_handler, 0, + dev_name(&pdev->dev), dmac); if (ret) goto err_unregister_of; @@ -711,7 +712,6 @@ static int axi_dmac_remove(struct platform_device *pdev) struct axi_dmac *dmac = platform_get_drvdata(pdev); of_dma_controller_free(pdev->dev.of_node); - free_irq(dmac->irq, dmac); tasklet_kill(&dmac->chan.vchan.task); dma_async_device_unregister(&dmac->dma_dev); clk_disable_unprepare(dmac->clk);