diff mbox

[2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

Message ID 20180426161239.15234-2-mdf@kernel.org (mailing list archive)
State Not Applicable
Headers show

Commit Message

Moritz Fischer April 26, 2018, 4:12 p.m. UTC
Request IRQ with IRQF_SHARED flag. This works since the interrupt
handler already checks if there is an actual IRQ pending and returns
IRQ_NONE otherwise.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
 drivers/dma/dma-axi-dmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lars-Peter Clausen April 26, 2018, 4:27 p.m. UTC | #1
On 04/26/2018 06:12 PM, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

> ---
>  drivers/dma/dma-axi-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 75ccedaa96d2..2bd195532882 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -688,7 +688,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>  		goto err_unregister_device;
>  
>  	ret = devm_request_irq(&pdev->dev, dmac->irq,
> -			       axi_dmac_interrupt_handler, 0,
> +			       axi_dmac_interrupt_handler, IRQF_SHARED,
>  			       dev_name(&pdev->dev), dmac);
>  	if (ret)
>  		goto err_unregister_of;
> 

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 75ccedaa96d2..2bd195532882 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -688,7 +688,7 @@  static int axi_dmac_probe(struct platform_device *pdev)
 		goto err_unregister_device;
 
 	ret = devm_request_irq(&pdev->dev, dmac->irq,
-			       axi_dmac_interrupt_handler, 0,
+			       axi_dmac_interrupt_handler, IRQF_SHARED,
 			       dev_name(&pdev->dev), dmac);
 	if (ret)
 		goto err_unregister_of;