diff mbox

dmaengine: k3dma: Off by one in k3_of_dma_simple_xlate()

Message ID 20180622111547.urjjagjf6rxbobpq@kili.mountain (mailing list archive)
State Accepted
Headers show

Commit Message

Dan Carpenter June 22, 2018, 11:15 a.m. UTC 
The d->chans[] array has d->dma_requests elements so the > should be
>= here.

Fixes: 8e6152bc660e ("dmaengine: Add hisilicon k3 DMA engine driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Vinod Koul June 28, 2018, 6:27 a.m. UTC | #1 
On 22-06-18, 14:15, Dan Carpenter wrote:
> The d->chans[] array has d->dma_requests elements so the > should be
> >= here.

Applied, thanks
diff mbox

Patch

diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
index fa31cccbe04f..6bfa217ed6d0 100644
--- a/drivers/dma/k3dma.c
+++ b/drivers/dma/k3dma.c
@@ -794,7 +794,7 @@  static struct dma_chan *k3_of_dma_simple_xlate(struct of_phandle_args *dma_spec,
 	struct k3_dma_dev *d = ofdma->of_dma_data;
 	unsigned int request = dma_spec->args[0];
 
-	if (request > d->dma_requests)
+	if (request >= d->dma_requests)
 		return NULL;
 
 	return dma_get_slave_channel(&(d->chans[request].vc.chan));