Message ID | 20180803072016.21544-40-sjhuang@iluvatar.ai (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <dmaengine-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6219D13BB for <patchwork-dmaengine@patchwork.kernel.org>; Fri, 3 Aug 2018 07:21:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45928286B0 for <patchwork-dmaengine@patchwork.kernel.org>; Fri, 3 Aug 2018 07:21:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3935F2C5B7; Fri, 3 Aug 2018 07:21:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA27E286B0 for <patchwork-dmaengine@patchwork.kernel.org>; Fri, 3 Aug 2018 07:21:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732621AbeHCJQn (ORCPT <rfc822;patchwork-dmaengine@patchwork.kernel.org>); Fri, 3 Aug 2018 05:16:43 -0400 Received: from mail.iluvatar.ai ([58.213.90.100]:57868 "EHLO mail.iluvatar.ai" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732616AbeHCJQn (ORCPT <rfc822;dmaengine@vger.kernel.org>); Fri, 3 Aug 2018 05:16:43 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.iluvatar.ai (Postfix) with ESMTP id C78B6107081FC; Fri, 3 Aug 2018 15:25:24 +0800 (CST) Received: from mail.iluvatar.ai ([127.0.0.1]) by localhost (mail.iluvatar.ai [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zvIXhIildtni; Fri, 3 Aug 2018 15:25:24 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by mail.iluvatar.ai (Postfix) with ESMTP id 6D0E113C8D166; Fri, 3 Aug 2018 15:25:24 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.9.2 mail.iluvatar.ai 6D0E113C8D166 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iluvatar.ai; s=809B2F8E-810B-11E8-86FD-A0A654EEFFEB; t=1533281124; bh=1BNkp2l6cXzeFs5h98vV4AlVKEZMTiTUjieZBVXoUWE=; h=From:To:Subject:Date:Message-Id; b=FXqzgB3GEGW+DKROzNoLwW8yaDGj6/kTktKd/6rW+0fUgNu4+qGYR4RPb/HH65a5V 7EcL2TbX3pJWXnHflz3R9gKDiSmJttMnmWItLmRftvQKPisH2Zz37FWtTHGOWZfwyL v/2IYzpRAow2y0TqUStxum03Y/ZSmS4+jwyGjhFc= X-Virus-Scanned: amavisd-new at iluvatar.ai Received: from mail.iluvatar.ai ([127.0.0.1]) by localhost (mail.iluvatar.ai [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CFP3JaMPXKQ9; Fri, 3 Aug 2018 15:25:24 +0800 (CST) Received: from localhost.localdomain (unknown [180.166.124.10]) by mail.iluvatar.ai (Postfix) with ESMTPSA id C31DA107081FA; Fri, 3 Aug 2018 15:25:23 +0800 (CST) From: Huang Shijie <sjhuang@iluvatar.ai> To: vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, dave.jiang@intel.com, radhey.shyam.pandey@xilinx.com, appana.durga.rao@xilinx.com, jmkrzyszt@gmail.com, gomonovych@gmail.com, peter.ujfalusi@ti.com, keescook@chromium.org, horms+renesas@verge.net.au, geert+renesas@glider.be, shawnguo@kernel.org, baoyou.xie@linaro.org, michal.simek@xilinx.com, baohua@kernel.org, ludovic.desroches@microchip.com, linus.walleij@linaro.org, david.brown@linaro.org, Huang Shijie <sjhuang@iluvatar.ai> Subject: [PATCH 39/46] dmaengine: img-mdc-dma: use dmaenginem_async_device_register to simplify the code Date: Fri, 3 Aug 2018 15:20:09 +0800 Message-Id: <20180803072016.21544-40-sjhuang@iluvatar.ai> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180803072016.21544-1-sjhuang@iluvatar.ai> References: <20180803072016.21544-1-sjhuang@iluvatar.ai> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: <dmaengine.vger.kernel.org> X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
Use dmaenginem_async_device_register to simplify code
|
expand
|
diff --git a/drivers/dma/img-mdc-dma.c b/drivers/dma/img-mdc-dma.c index 25cec9c243e1..1e555ac62b1e 100644 --- a/drivers/dma/img-mdc-dma.c +++ b/drivers/dma/img-mdc-dma.c @@ -1001,21 +1001,19 @@ static int mdc_dma_probe(struct platform_device *pdev) return ret; } - ret = dma_async_device_register(&mdma->dma_dev); + ret = dmaenginem_async_device_register(&mdma->dma_dev); if (ret) goto suspend; ret = of_dma_controller_register(pdev->dev.of_node, mdc_of_xlate, mdma); if (ret) - goto unregister; + goto suspend; dev_info(&pdev->dev, "MDC with %u channels and %u threads\n", mdma->nr_channels, mdma->nr_threads); return 0; -unregister: - dma_async_device_unregister(&mdma->dma_dev); suspend: if (!pm_runtime_enabled(&pdev->dev)) img_mdc_runtime_suspend(&pdev->dev); @@ -1029,7 +1027,6 @@ static int mdc_dma_remove(struct platform_device *pdev) struct mdc_chan *mchan, *next; of_dma_controller_free(pdev->dev.of_node); - dma_async_device_unregister(&mdma->dma_dev); list_for_each_entry_safe(mchan, next, &mdma->dma_dev.channels, vc.chan.device_node) {
Use dmaenginem_async_device_register to simplify the code: remove dma_async_device_unregister remove label unregister Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai> --- drivers/dma/img-mdc-dma.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)