| Message ID | 20180806085231.4597-4-sjhuang@iluvatar.ai (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: Use dmaenginem_async_device_register to simplify the code | expand |
On Monday, August 06, 2018 10:52 AM, Huang Shijie wrote: > Use dmaenginem_async_device_register to simplify the code: > remove dma_async_device_unregister. > > Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai> > --- > drivers/dma/st_fdma.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c > index bfb79bd0c6de..7eafccd4f7f5 100644 > --- a/drivers/dma/st_fdma.c > +++ b/drivers/dma/st_fdma.c > @@ -833,7 +833,7 @@ static int st_fdma_probe(struct platform_device *pdev) > fdev->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); > fdev->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; > > - ret = dma_async_device_register(&fdev->dma_device); > + ret = dmaenginem_async_device_register(&fdev->dma_device); > if (ret) { > dev_err(&pdev->dev, > "Failed to register DMA device (%d)\n", ret); > @@ -852,7 +852,6 @@ static int st_fdma_probe(struct platform_device *pdev) > return 0; > > err_dma_dev: > - dma_async_device_unregister(&fdev->dma_device); I guess the jump label can go away too? Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 06, 2018 at 11:03:51AM +0200, Daniel Mack wrote: > > - ret = dma_async_device_register(&fdev->dma_device); > > + ret = dmaenginem_async_device_register(&fdev->dma_device); > > if (ret) { > > dev_err(&pdev->dev, > > "Failed to register DMA device (%d)\n", ret); > > @@ -852,7 +852,6 @@ static int st_fdma_probe(struct platform_device *pdev) > > return 0; > > err_dma_dev: > > - dma_async_device_unregister(&fdev->dma_device); > > I guess the jump label can go away too? Yes. We can remove the err_dma_dev too. Thanks Huang Shijie -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c index bfb79bd0c6de..7eafccd4f7f5 100644 --- a/drivers/dma/st_fdma.c +++ b/drivers/dma/st_fdma.c @@ -833,7 +833,7 @@ static int st_fdma_probe(struct platform_device *pdev) fdev->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); fdev->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; - ret = dma_async_device_register(&fdev->dma_device); + ret = dmaenginem_async_device_register(&fdev->dma_device); if (ret) { dev_err(&pdev->dev, "Failed to register DMA device (%d)\n", ret); @@ -852,7 +852,6 @@ static int st_fdma_probe(struct platform_device *pdev) return 0; err_dma_dev: - dma_async_device_unregister(&fdev->dma_device); err_rproc: st_fdma_free(fdev); st_slim_rproc_put(fdev->slim_rproc); @@ -867,7 +866,6 @@ static int st_fdma_remove(struct platform_device *pdev) devm_free_irq(&pdev->dev, fdev->irq, fdev); st_slim_rproc_put(fdev->slim_rproc); of_dma_controller_free(pdev->dev.of_node); - dma_async_device_unregister(&fdev->dma_device); return 0; }
Use dmaenginem_async_device_register to simplify the code: remove dma_async_device_unregister. Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai> --- drivers/dma/st_fdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)