| Message ID | 20190328133828.20999-2-angus@akkea.ca (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix imx8mq ratio 1:1 check | expand |
On Thu, 2019-03-28 at 06:38 -0700, Angus Ainslie (Purism) wrote: > Fix a typo in the compatible string > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> Reviwed-by: Daniel Baluta <daniel.baluta@nxp.com>
> From: Angus Ainslie (Purism) [mailto:angus@akkea.ca] > Sent: Thursday, March 28, 2019 9:38 PM > > Fix a typo in the compatible string > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 81d5ce1b1ec1..07099f82965e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -720,7 +720,7 @@ > }; > > sdma1: sdma@30bd0000 { > - compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma"; > + compatible = "fsl,mx8mq-sdma","fsl,imx7d-sdma"; This is a bit strange. If binding doc says like that, probably we'd better fix the typo in binding doc to use the same style. Regards Dong Aisheng > reg = <0x30bd0000 0x10000>; > interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>, > -- > 2.17.1
On Fri, Mar 29, 2019 at 11:11 AM Aisheng Dong <aisheng.dong@nxp.com> wrote: > > > From: Angus Ainslie (Purism) [mailto:angus@akkea.ca] > > Sent: Thursday, March 28, 2019 9:38 PM > > > > Fix a typo in the compatible string > > > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > > --- > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > index 81d5ce1b1ec1..07099f82965e 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > @@ -720,7 +720,7 @@ > > }; > > > > sdma1: sdma@30bd0000 { > > - compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma"; > > + compatible = "fsl,mx8mq-sdma","fsl,imx7d-sdma"; > > This is a bit strange. > If binding doc says like that, probably we'd better fix the typo in binding doc > to use the same style. Oh, indeed. Angus, shouldn't this be fsl,imx8mq-sdma instead of fsl,mx8mq-sdma. I was just paying attention to the extra space in my patch.
On 2019-03-29 04:20, Daniel Baluta wrote: > On Fri, Mar 29, 2019 at 11:11 AM Aisheng Dong <aisheng.dong@nxp.com> > wrote: >> >> > From: Angus Ainslie (Purism) [mailto:angus@akkea.ca] >> > Sent: Thursday, March 28, 2019 9:38 PM >> > >> > Fix a typo in the compatible string >> > >> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> >> > --- >> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> > index 81d5ce1b1ec1..07099f82965e 100644 >> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> > @@ -720,7 +720,7 @@ >> > }; >> > >> > sdma1: sdma@30bd0000 { >> > - compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma"; >> > + compatible = "fsl,mx8mq-sdma","fsl,imx7d-sdma"; >> >> This is a bit strange. >> If binding doc says like that, probably we'd better fix the typo in >> binding doc >> to use the same style. > > Oh, indeed. > > Angus, shouldn't this be fsl,imx8mq-sdma instead of fsl,mx8mq-sdma. I > was just paying > attention to the extra space in my patch. Correct I took too many characters when I dropped the space. I'll fix it for v2. Angus
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 81d5ce1b1ec1..07099f82965e 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -720,7 +720,7 @@ }; sdma1: sdma@30bd0000 { - compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma"; + compatible = "fsl,mx8mq-sdma","fsl,imx7d-sdma"; reg = <0x30bd0000 0x10000>; interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>,
Fix a typo in the compatible string Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)