| Message ID | 20190503131507.GA1236@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: at_xdmac: remove a stray bottom half unlock | expand |
On 03-05-19, 16:15, Dan Carpenter wrote: > We switched this code from spin_lock_bh() to vanilla spin_lock() but > there was one stray spin_unlock_bh() that was overlooked. This > patch converts it to spin_unlock() as well. Applied, thanks
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 06cbe54e4c30..e4ae2ee46d3f 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -1655,7 +1655,7 @@ static void at_xdmac_tasklet(unsigned long data) dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc); if (!desc->active_xfer) { dev_err(chan2dev(&atchan->chan), "Xfer not active: exiting"); - spin_unlock_bh(&atchan->lock); + spin_unlock(&atchan->lock); return; }
We switched this code from spin_lock_bh() to vanilla spin_lock() but there was one stray spin_unlock_bh() that was overlooked. This patch converts it to spin_unlock() as well. Fixes: d8570d018f69 ("dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/dma/at_xdmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)