| Message ID | 20190612041954.256-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] dmaengine: dw-edma: Fix build error without CONFIG_PCI_MSI | expand |
On 12-06-19, 12:19, YueHaibing wrote: > If CONFIG_PCI_MSI is not set, building with CONFIG_DW_EDMA > fails: > > drivers/dma/dw-edma/dw-edma-core.c: In function dw_edma_irq_request: > drivers/dma/dw-edma/dw-edma-core.c:784:21: error: implicit declaration of function pci_irq_vector; did you mean rcu_irq_enter? [-Werror=implicit-function-declaration] > err = request_irq(pci_irq_vector(to_pci_dev(dev), 0), > ^~~~~~~~~~~~~~ Applied with adding reported by Randy as well, thanks > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/dma/dw-edma/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/dw-edma/Kconfig b/drivers/dma/dw-edma/Kconfig > index c0838ce..7ff17b2 100644 > --- a/drivers/dma/dw-edma/Kconfig > +++ b/drivers/dma/dw-edma/Kconfig > @@ -2,6 +2,7 @@ > > config DW_EDMA > tristate "Synopsys DesignWare eDMA controller driver" > + depends on PCI && PCI_MSI > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > help > -- > 2.7.4 >
diff --git a/drivers/dma/dw-edma/Kconfig b/drivers/dma/dw-edma/Kconfig index c0838ce..7ff17b2 100644 --- a/drivers/dma/dw-edma/Kconfig +++ b/drivers/dma/dw-edma/Kconfig @@ -2,6 +2,7 @@ config DW_EDMA tristate "Synopsys DesignWare eDMA controller driver" + depends on PCI && PCI_MSI select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help
If CONFIG_PCI_MSI is not set, building with CONFIG_DW_EDMA fails: drivers/dma/dw-edma/dw-edma-core.c: In function dw_edma_irq_request: drivers/dma/dw-edma/dw-edma-core.c:784:21: error: implicit declaration of function pci_irq_vector; did you mean rcu_irq_enter? [-Werror=implicit-function-declaration] err = request_irq(pci_irq_vector(to_pci_dev(dev), 0), ^~~~~~~~~~~~~~ Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/dma/dw-edma/Kconfig | 1 + 1 file changed, 1 insertion(+)