| Message ID | 20190612122557.24158-1-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/6] dma: amba-pl08x: no need to cast away call to debugfs_create_file() | expand |
On 12-06-19, 14:25, Greg Kroah-Hartman wrote: > No need to check the return value of debugfs_create_file(), so no need > to provide a fake "cast away" of the return value either. Applied all after fixing the subsystem tag (dmaengine), thanks
On Fri, Jun 14, 2019 at 11:16:13AM +0530, Vinod Koul wrote: > On 12-06-19, 14:25, Greg Kroah-Hartman wrote: > > No need to check the return value of debugfs_create_file(), so no need > > to provide a fake "cast away" of the return value either. > > Applied all after fixing the subsystem tag (dmaengine), thanks Sorry about that, and thanks! greg k-h
On Fri, Jun 14, 2019 at 11:16:13AM +0530, Vinod Koul wrote: > On 12-06-19, 14:25, Greg Kroah-Hartman wrote: > > No need to check the return value of debugfs_create_file(), so no need > > to provide a fake "cast away" of the return value either. > > Applied all after fixing the subsystem tag (dmaengine), thanks Oops, messed that up, sorry. Thanks for applying them! greg k-h
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 464725dcad00..9adc7a2fa3d3 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -2508,9 +2508,8 @@ DEFINE_SHOW_ATTRIBUTE(pl08x_debugfs); static void init_pl08x_debugfs(struct pl08x_driver_data *pl08x) { /* Expose a simple debugfs interface to view all clocks */ - (void) debugfs_create_file(dev_name(&pl08x->adev->dev), - S_IFREG | S_IRUGO, NULL, pl08x, - &pl08x_debugfs_fops); + debugfs_create_file(dev_name(&pl08x->adev->dev), S_IFREG | S_IRUGO, + NULL, pl08x, &pl08x_debugfs_fops); } #else
No need to check the return value of debugfs_create_file(), so no need to provide a fake "cast away" of the return value either. Cc: Dan Williams <dan.j.williams@intel.com> Cc: Vinod Koul <vkoul@kernel.org> Cc: dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/dma/amba-pl08x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)