| Message ID | 20190612122557.24158-5-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/6] dma: amba-pl08x: no need to cast away call to debugfs_create_file() | expand |
On Wed, 2019-06-12 at 14:25 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > Thanks Greg. Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com> > Cc: Sudeep Dutt <sudeep.dutt@intel.com> > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: dmaengine@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/dma/mic_x100_dma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c > index 6a91e28d537d..584e09661507 100644 > --- a/drivers/dma/mic_x100_dma.c > +++ b/drivers/dma/mic_x100_dma.c > @@ -728,10 +728,8 @@ static int mic_dma_driver_probe(struct mbus_device *mbdev) > if (mic_dma_dbg) { > mic_dma_dev->dbg_dir = debugfs_create_dir(dev_name(&mbdev->dev), > mic_dma_dbg); > - if (mic_dma_dev->dbg_dir) > - debugfs_create_file("mic_dma_reg", 0444, > - mic_dma_dev->dbg_dir, mic_dma_dev, > - &mic_dma_reg_fops); > + debugfs_create_file("mic_dma_reg", 0444, mic_dma_dev->dbg_dir, > + mic_dma_dev, &mic_dma_reg_fops); > } > return 0; > }
diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c index 6a91e28d537d..584e09661507 100644 --- a/drivers/dma/mic_x100_dma.c +++ b/drivers/dma/mic_x100_dma.c @@ -728,10 +728,8 @@ static int mic_dma_driver_probe(struct mbus_device *mbdev) if (mic_dma_dbg) { mic_dma_dev->dbg_dir = debugfs_create_dir(dev_name(&mbdev->dev), mic_dma_dbg); - if (mic_dma_dev->dbg_dir) - debugfs_create_file("mic_dma_reg", 0444, - mic_dma_dev->dbg_dir, mic_dma_dev, - &mic_dma_reg_fops); + debugfs_create_file("mic_dma_reg", 0444, mic_dma_dev->dbg_dir, + mic_dma_dev, &mic_dma_reg_fops); } return 0; }
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Sudeep Dutt <sudeep.dutt@intel.com> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Vinod Koul <vkoul@kernel.org> Cc: dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/dma/mic_x100_dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)