From patchwork Mon Jan 6 01:16:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 11318615 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5C25D14B4 for ; Mon, 6 Jan 2020 01:18:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3ACCF217F4 for ; Mon, 6 Jan 2020 01:18:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V/YNpxKO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727296AbgAFBRZ (ORCPT ); Sun, 5 Jan 2020 20:17:25 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:35062 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727218AbgAFBRY (ORCPT ); Sun, 5 Jan 2020 20:17:24 -0500 Received: by mail-lj1-f194.google.com with SMTP id j1so41895483lja.2; Sun, 05 Jan 2020 17:17:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v3aEWiKiUIKlnyGDWrJTtogZVkNTJgIo6DWcgGLcpCo=; b=V/YNpxKOpbuRP2Mk+3oJ1FAOc1QVwQHLvTJkNfW3SlJCZk/0tOOlYUBdLpzFHpEjFt sss9KhNvLOX3BjjVJ0eRwtZ4ZNQpNlHEG3N8IluHiJSxqFL30IZRQbE+Smgg8ZGuNVRA omVppVsDLM9Ofbpq6+Y97yz+witqyIy7mNQ4nbO0+HVu4tvVILnP10J6jE+Zh5nr497P FWlGGcQjkZOfInHu+zVotjdEwewXIbHvhCpHP+NXlau5Y74Wy/9f4a+GeJqGd9U8ZAWY f9d+Hg1aNEWwnXuQLr6pVV11qAr8lB5AtWS2e9NjbA1ICXyW8tvjoniNreRNcVjgi3iS +D1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v3aEWiKiUIKlnyGDWrJTtogZVkNTJgIo6DWcgGLcpCo=; b=s2XlPrHbrYH6igBAR9xHhHbT8S1prZsbLscjtwa9Ix2iXxgtulTD34BXppGY7Z2sLE mJRhYi7k84FwkDwvAACpPbfo0T0neHON9KZLFXk5LFFfBhRTnQXEDLAkmAop4cEUL8Vb vfe3MrhbYz2K/xf3/+SkX0G/uj2jkZjsO7WfY0AHqeUn8rNUVBZuxXo7iM72TEU3y1c0 D0S/i3klgh2QGVhT4tVNFOqeDe8FbzGEXfjzMcvHFVGt4W4voH3Pw2HTUQSTuLv8F3fR u60j9xxJJjq+fUIahUvJdrD3xmapfzYppY3z+OXjhLlw8gKDYAFhGCeE9Yc6TuGgaUcF IS2Q== X-Gm-Message-State: APjAAAWIWhXh542zLKQnV/gXPbsvYS72XTxsTvldiFNVBK93dDGQ7W8s 3HTYKxhqNZvafMDOS3qOREo= X-Google-Smtp-Source: APXvYqznTkwiEcbSztg51iNbsMG4w7FcJP55xh+LJ8yg4y8/Eq+y5rOvwizusi3MeN/jLJXL7lMobg== X-Received: by 2002:a2e:810d:: with SMTP id d13mr59185866ljg.113.1578273442447; Sun, 05 Jan 2020 17:17:22 -0800 (PST) Received: from localhost.localdomain (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.gmail.com with ESMTPSA id y14sm28353271ljk.46.2020.01.05.17.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2020 17:17:22 -0800 (PST) From: Dmitry Osipenko To: Laxman Dewangan , Vinod Koul , Dan Williams , Thierry Reding , Jonathan Hunter , =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 01/13] dmaengine: tegra-apb: Fix use-after-free Date: Mon, 6 Jan 2020 04:16:56 +0300 Message-Id: <20200106011708.7463-2-digetx@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20200106011708.7463-1-digetx@gmail.com> References: <20200106011708.7463-1-digetx@gmail.com> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org I was doing some experiments with I2C and noticed that Tegra APB DMA driver crashes sometime after I2C DMA transfer termination. The crash happens because tegra_dma_terminate_all() bails out immediately if pending list is empty, thus it doesn't release the half-completed descriptors which are getting re-used before ISR tasklet kicks-in. tegra-i2c 7000c400.i2c: DMA transfer timeout elants_i2c 0-0010: elants_i2c_irq: failed to read data: -110 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 142 at lib/list_debug.c:45 __list_del_entry_valid+0x45/0xac list_del corruption, ddbaac44->next is LIST_POISON1 (00000100) Modules linked in: CPU: 0 PID: 142 Comm: kworker/0:2 Not tainted 5.5.0-rc2-next-20191220-00175-gc3605715758d-dirty #538 Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) Workqueue: events_freezable_power_ thermal_zone_device_check [] (unwind_backtrace) from [] (show_stack+0x11/0x14) [] (show_stack) from [] (dump_stack+0x85/0x94) [] (dump_stack) from [] (__warn+0xc1/0xc4) [] (__warn) from [] (warn_slowpath_fmt+0x61/0x78) [] (warn_slowpath_fmt) from [] (__list_del_entry_valid+0x45/0xac) [] (__list_del_entry_valid) from [] (tegra_dma_tasklet+0x5b/0x154) [] (tegra_dma_tasklet) from [] (tasklet_action_common.constprop.0+0x41/0x7c) [] (tasklet_action_common.constprop.0) from [] (__do_softirq+0xd3/0x2a8) [] (__do_softirq) from [] (irq_exit+0x7b/0x98) [] (irq_exit) from [] (__handle_domain_irq+0x45/0x80) [] (__handle_domain_irq) from [] (gic_handle_irq+0x45/0x7c) [] (gic_handle_irq) from [] (__irq_svc+0x65/0x94) Exception stack(0xde2ebb90 to 0xde2ebbd8) Cc: Signed-off-by: Dmitry Osipenko --- drivers/dma/tegra20-apb-dma.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 3a45079d11ec..319f31d27014 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -756,10 +756,6 @@ static int tegra_dma_terminate_all(struct dma_chan *dc) bool was_busy; spin_lock_irqsave(&tdc->lock, flags); - if (list_empty(&tdc->pending_sg_req)) { - spin_unlock_irqrestore(&tdc->lock, flags); - return 0; - } if (!tdc->busy) goto skip_dma_stop;