| Message ID | 20200121070104.4393-1-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: ti: k3-psil: Fix warnings with C=1 and W=1 | expand |
On 21-01-20, 09:01, Peter Ujfalusi wrote: > Fixes the following warnings: > drivers/dma/ti/k3-psil-j721e.c:62:16: warning: symbol 'j721e_src_ep_map' was not declared. Should it be static? > drivers/dma/ti/k3-psil-j721e.c:172:16: warning: symbol 'j721e_dst_ep_map' was not declared. Should it be static? > drivers/dma/ti/k3-psil-j721e.c:216:20: warning: symbol 'j721e_ep_map' was not declared. Should it be static? > CC drivers/dma/ti/k3-psil-j721e.o > drivers/dma/ti/k3-psil-am654.c:52:16: warning: symbol 'am654_src_ep_map' was not declared. Should it be static? > drivers/dma/ti/k3-psil-am654.c:127:16: warning: symbol 'am654_dst_ep_map' was not declared. Should it be static? > drivers/dma/ti/k3-psil-am654.c:169:20: warning: symbol 'am654_ep_map' was not declared. Should it be static? We dont use titles like this :( A title should reflect the changes in the patch, I have updated this to "dmaengine: ti: k3-psil: make symbols static" and applied now
diff --git a/drivers/dma/ti/k3-psil-am654.c b/drivers/dma/ti/k3-psil-am654.c index 7da9242b6114..a896a15908cf 100644 --- a/drivers/dma/ti/k3-psil-am654.c +++ b/drivers/dma/ti/k3-psil-am654.c @@ -49,7 +49,7 @@ } /* PSI-L source thread IDs, used for RX (DMA_DEV_TO_MEM) */ -struct psil_ep am654_src_ep_map[] = { +static struct psil_ep am654_src_ep_map[] = { /* SA2UL */ PSIL_SA2UL(0x4000, 0), PSIL_SA2UL(0x4001, 0), @@ -124,7 +124,7 @@ struct psil_ep am654_src_ep_map[] = { }; /* PSI-L destination thread IDs, used for TX (DMA_MEM_TO_DEV) */ -struct psil_ep am654_dst_ep_map[] = { +static struct psil_ep am654_dst_ep_map[] = { /* SA2UL */ PSIL_SA2UL(0xc000, 1), PSIL_SA2UL(0xc001, 1), diff --git a/drivers/dma/ti/k3-psil-j721e.c b/drivers/dma/ti/k3-psil-j721e.c index a609d496fddd..e3cfd5f66842 100644 --- a/drivers/dma/ti/k3-psil-j721e.c +++ b/drivers/dma/ti/k3-psil-j721e.c @@ -59,7 +59,7 @@ } /* PSI-L source thread IDs, used for RX (DMA_DEV_TO_MEM) */ -struct psil_ep j721e_src_ep_map[] = { +static struct psil_ep j721e_src_ep_map[] = { /* SA2UL */ PSIL_SA2UL(0x4000, 0), PSIL_SA2UL(0x4001, 0), @@ -169,7 +169,7 @@ struct psil_ep j721e_src_ep_map[] = { }; /* PSI-L destination thread IDs, used for TX (DMA_MEM_TO_DEV) */ -struct psil_ep j721e_dst_ep_map[] = { +static struct psil_ep j721e_dst_ep_map[] = { /* SA2UL */ PSIL_SA2UL(0xc000, 1), PSIL_SA2UL(0xc001, 1), diff --git a/drivers/dma/ti/k3-psil-priv.h b/drivers/dma/ti/k3-psil-priv.h index f74420653d8a..a1f389ca371e 100644 --- a/drivers/dma/ti/k3-psil-priv.h +++ b/drivers/dma/ti/k3-psil-priv.h @@ -36,4 +36,8 @@ struct psil_ep_map { struct psil_endpoint_config *psil_get_ep_config(u32 thread_id); +/* SoC PSI-L endpoint maps */ +extern struct psil_ep_map am654_ep_map; +extern struct psil_ep_map j721e_ep_map; + #endif /* K3_PSIL_PRIV_H_ */ diff --git a/drivers/dma/ti/k3-psil.c b/drivers/dma/ti/k3-psil.c index 9314cf9a52e4..d7b965049ccb 100644 --- a/drivers/dma/ti/k3-psil.c +++ b/drivers/dma/ti/k3-psil.c @@ -12,9 +12,6 @@ #include "k3-psil-priv.h" -extern struct psil_ep_map am654_ep_map; -extern struct psil_ep_map j721e_ep_map; - static DEFINE_MUTEX(ep_map_mutex); static struct psil_ep_map *soc_ep_map;
Fixes the following warnings: drivers/dma/ti/k3-psil-j721e.c:62:16: warning: symbol 'j721e_src_ep_map' was not declared. Should it be static? drivers/dma/ti/k3-psil-j721e.c:172:16: warning: symbol 'j721e_dst_ep_map' was not declared. Should it be static? drivers/dma/ti/k3-psil-j721e.c:216:20: warning: symbol 'j721e_ep_map' was not declared. Should it be static? CC drivers/dma/ti/k3-psil-j721e.o drivers/dma/ti/k3-psil-am654.c:52:16: warning: symbol 'am654_src_ep_map' was not declared. Should it be static? drivers/dma/ti/k3-psil-am654.c:127:16: warning: symbol 'am654_dst_ep_map' was not declared. Should it be static? drivers/dma/ti/k3-psil-am654.c:169:20: warning: symbol 'am654_ep_map' was not declared. Should it be static? Reported-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- Hi Vinod, Thanks for catching it! This is on top of the v8 series. Regards, Peter drivers/dma/ti/k3-psil-am654.c | 4 ++-- drivers/dma/ti/k3-psil-j721e.c | 4 ++-- drivers/dma/ti/k3-psil-priv.h | 4 ++++ drivers/dma/ti/k3-psil.c | 3 --- 4 files changed, 8 insertions(+), 7 deletions(-)