From patchwork Tue Jul 14 11:15:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662387 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6CC2A13A4 for ; Tue, 14 Jul 2020 11:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E5A62220D for ; Tue, 14 Jul 2020 11:19:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pHR0K+KI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726928AbgGNLTP (ORCPT ); Tue, 14 Jul 2020 07:19:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727919AbgGNLQr (ORCPT ); Tue, 14 Jul 2020 07:16:47 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C8ACC08C5F8 for ; Tue, 14 Jul 2020 04:16:01 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r12so20829525wrj.13 for ; Tue, 14 Jul 2020 04:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AREbkFQeq62jMhEbsCGiKpcIyUmzmEoBeESlFrgp8DE=; b=pHR0K+KIKxD5EhQKwXJRi/S4mxtDdDxisRS89L6rsYWjar6xsf8yjwNVsm+/g1upct IjWqNYsequpP4EokGC40Vu6cXEx/yZuCdZaq0N3/OFVgliYwoxdDkSpoT0u76/HuKY6U MUbzo7YLYjjS7/pll5iVgV7Q58ymHgPYlsRuP2liz2R5WxN22Oi1Kk4KwrQO9/oZusKt OQkwybdZ3gHPd3FOQszTItGnFNRuTo22n7TnlJGNSowr7quZ7wNDgooiGSqS4dtCo1t5 8Tcq5cilV0VQoGtWhZTw8JfUhrmhODcrz7h4EDAXTRcu12wQcylbZ4ozZzb2AmspBtFl XHAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AREbkFQeq62jMhEbsCGiKpcIyUmzmEoBeESlFrgp8DE=; b=sxXqBfjcoq6u0/Hb5rBuTLG7D0N+6zUKLAE/ArLzret52Sio6ZAxQsD7WLSEUIz1sp BYYCEBc0nlADbZRRabtTItsSzzjXr7yEw5qg4wl1H70VoZfzuddvDWETsS0k3sGTHexZ F7s5wF7oux2OByIiKx8baVxk27//2QCh083BTFI3CyEeePBPTBJlQlXqN5HXGHMe8/78 2i7spFlfi2ZyWxwItD4G1obAx77zP71nzlqtaLyChEzt5lc0iMLzvnkUAib2sqy/KYXv Pms1GWhtNCHDqI4N+LyB23/FFPAGJWUn5vRz+qq91fxGRRS7O+nn086ykNAQ1wJRHvJb 6IeA== X-Gm-Message-State: AOAM532zmM48aFjxb8VODNmU0GAStq1jEmefEZGOlZQmkkkPyqcuLnRE dd2eJlIH6Nsr9KjJ23mEDrE+sg== X-Google-Smtp-Source: ABdhPJyAH8JGNWD20qUSqWUGbGK+bbNu7uHkKBBKvWNRnQi1cZAEQOcb1acarwwp6TN9Ch6DTWsG9A== X-Received: by 2002:a5d:420b:: with SMTP id n11mr4591674wrq.91.1594725359812; Tue, 14 Jul 2020 04:15:59 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:59 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Maxime Ripard , Chen-Yu Tsai , =?utf-8?q?Emilio_L=C3=B3pez?= Subject: [PATCH 09/17] dma: sun4i-dma: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 14 Jul 2020 12:15:38 +0100 Message-Id: <20200714111546.1755231-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/dma/sun4i-dma.c:321: warning: Function parameter or member 'priv' not described in '__execute_vchan_pending' drivers/dma/sun4i-dma.c:321: warning: Function parameter or member 'vchan' not described in '__execute_vchan_pending' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'chan' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'src' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'dest' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'len' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'sconfig' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'direction' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'chan' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'src' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'dest' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'len' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'sconfig' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:577: warning: Function parameter or member 'contract' not described in 'get_next_cyclic_promise' drivers/dma/sun4i-dma.c:596: warning: Function parameter or member 'vd' not described in 'sun4i_dma_free_contract' Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: "Emilio López" Signed-off-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/dma/sun4i-dma.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c index e7ff09a5031db..e8b6633ae6612 100644 --- a/drivers/dma/sun4i-dma.c +++ b/drivers/dma/sun4i-dma.c @@ -307,7 +307,7 @@ static void set_pchan_interrupt(struct sun4i_dma_dev *priv, spin_unlock_irqrestore(&priv->lock, flags); } -/** +/* * Execute pending operations on a vchan * * When given a vchan, this function will try to acquire a suitable @@ -419,7 +419,7 @@ static int sanitize_config(struct dma_slave_config *sconfig, return 0; } -/** +/* * Generate a promise, to be used in a normal DMA contract. * * A NDMA promise contains all the information required to program the @@ -486,7 +486,7 @@ generate_ndma_promise(struct dma_chan *chan, dma_addr_t src, dma_addr_t dest, return NULL; } -/** +/* * Generate a promise, to be used in a dedicated DMA contract. * * A DDMA promise contains all the information required to program the @@ -543,7 +543,7 @@ generate_ddma_promise(struct dma_chan *chan, dma_addr_t src, dma_addr_t dest, return NULL; } -/** +/* * Generate a contract * * Contracts function as DMA descriptors. As our hardware does not support @@ -565,7 +565,7 @@ static struct sun4i_dma_contract *generate_dma_contract(void) return contract; } -/** +/* * Get next promise on a cyclic transfer * * Cyclic contracts contain a series of promises which are executed on a @@ -589,7 +589,7 @@ get_next_cyclic_promise(struct sun4i_dma_contract *contract) return promise; } -/** +/* * Free a contract and all its associated promises */ static void sun4i_dma_free_contract(struct virt_dma_desc *vd)