From patchwork Tue Jul 14 11:15:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662407 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1C87313B4 for ; Tue, 14 Jul 2020 11:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02BA92082F for ; Tue, 14 Jul 2020 11:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r07S7f0J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727989AbgGNLUT (ORCPT ); Tue, 14 Jul 2020 07:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728144AbgGNLSm (ORCPT ); Tue, 14 Jul 2020 07:18:42 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 531D2C08E8A0 for ; Tue, 14 Jul 2020 04:16:08 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j4so20884339wrp.10 for ; Tue, 14 Jul 2020 04:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ewSSWUW/45nS/yx3Bple4Rafu63cuthV60wjjsFm31o=; b=r07S7f0JSGNo1Nt9IZFRGGvi9Lp2WCC0rUzVkAvOq5O5uuetYvLH26mbxDtnyAveOz frcZe2zibwjQUBdEtszl73MgfdEyhSWZPApwvfZbtovOiVCL+WQ62RhmhxnQcZamm8Xu 3/+y9QgaGUFjp0zbF74w49tY4gMxtfrYEhyvpwi1E5zAnvOXnxeahcfETAjZ8zxWDFQR y8d4IbJ64kqiAxtEplpKCvRtSMPMDLwDzaSZYdo7ZjIcV83l6ES2n2CSsfPa7S0tsFm2 WaARQ9l+CbHGQ1v3IShviPOp0RquLwYS1UYGGtDANowawECxzEayp2QTi3YOTEl+9InD KT1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ewSSWUW/45nS/yx3Bple4Rafu63cuthV60wjjsFm31o=; b=s2QVfiZAZwghiNqiH1t4UCpFZN/UAuRmr0vLqDmv12mqlSAzyvRoLiRph1AYWDThq+ fUJYzpkKxd4KN2CvTX1ZhKNVsOPqg6Tq9kzp4RJMA8mqCbVjeExbDHP4ausgVI6qHABT wMBFcYoOYG3ZhLahyyIBVUH1TSWtGTi7Wetos0nYwHtA4lBISmmN3NGP0+53z9z4BXyv j6+ceZbqEILkwMdkdoqs3864EpFJvdVuZ94tnpi22H82sT5lJt9ep4oighTaOcCrfFU5 ZnXsj6+7iYVDknNitk9L6bEDaqr0smy8EY4+NTKd9eF0tKb/UKwqj0j8Fj7nyC7ArspE Uu0g== X-Gm-Message-State: AOAM532n6xJIrHpoc46cxyLZq2Ixmy07zlEsp6ZCP78NBvIPphg1kSZK tIkCVIAu7uvxukjQ/fenfADh8A== X-Google-Smtp-Source: ABdhPJwOpZLkCp6n4syZLc9H9p9CNZPkWXr22M9kvz71NJK/JQzp8BLfmFRHWp3bAZgklkl2RAAp0Q== X-Received: by 2002:a5d:4a42:: with SMTP id v2mr4330551wrs.33.1594725367098; Tue, 14 Jul 2020 04:16:07 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:06 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones Subject: [PATCH 15/17] dma: mv_xor_v2: Supply some missing 'struct mv_xor_v2_device' attribute docs Date: Tue, 14 Jul 2020 12:15:44 +0100 Message-Id: <20200714111546.1755231-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'clk' not described in 'mv_xor_v2_device' drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'reg_clk' not described in 'mv_xor_v2_device' drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'irq_tasklet' not described in 'mv_xor_v2_device' drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'hw_queue_idx' not described in 'mv_xor_v2_device' drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'msi_desc' not described in 'mv_xor_v2_device' Signed-off-by: Lee Jones --- drivers/dma/mv_xor_v2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c index 157c959311eaf..9225f08dfee92 100644 --- a/drivers/dma/mv_xor_v2.c +++ b/drivers/dma/mv_xor_v2.c @@ -135,9 +135,11 @@ struct mv_xor_v2_descriptor { /** * struct mv_xor_v2_device - implements a xor device * @lock: lock for the engine + * @clk: reference to the 'core' clock + * @reg_clk: reference to the 'reg' clock * @dma_base: memory mapped DMA register base * @glob_base: memory mapped global register base - * @irq_tasklet: + * @irq_tasklet: tasklet used for IRQ handling call-backs * @free_sw_desc: linked list of free SW descriptors * @dmadev: dma device * @dmachan: dma channel @@ -146,6 +148,8 @@ struct mv_xor_v2_descriptor { * @sw_desq: SW descriptors queue * @desc_size: HW descriptor size * @npendings: number of pending descriptors (for which tx_submit has + * @hw_queue_idx: HW queue index + * @msi_desc: local interrupt descriptor information * been called, but not yet issue_pending) */ struct mv_xor_v2_device {