diff mbox series

[2/3] dmaengine: xilinx: dpdma: add missing kernel doc

Message ID 20200718135201.191881-2-vkoul@kernel.org (mailing list archive)
State Accepted
Headers show
Series [1/3] dmaengine: xilinx: dpdma: remove comparison of unsigned expression | expand

Commit Message

Vinod Koul July 18, 2020, 1:52 p.m. UTC
xilinx_dpdma_sw_desc_set_dma_addrs() documentation is missing describing
'xdev', so add it

drivers/dma/xilinx/xilinx_dpdma.c:313: warning: Function parameter or
member 'xdev' not described in 'xilinx_dpdma_sw_desc_set_dma_addrs'

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/xilinx/xilinx_dpdma.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart July 22, 2020, 12:45 p.m. UTC | #1
Hi Vinod,

Thank you for the patch.

On Sat, Jul 18, 2020 at 07:22:00PM +0530, Vinod Koul wrote:
> xilinx_dpdma_sw_desc_set_dma_addrs() documentation is missing describing
> 'xdev', so add it
> 
> drivers/dma/xilinx/xilinx_dpdma.c:313: warning: Function parameter or
> member 'xdev' not described in 'xilinx_dpdma_sw_desc_set_dma_addrs'
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/dma/xilinx/xilinx_dpdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 8e602378f2dc..430f3714f6a3 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -295,6 +295,7 @@ static inline void dpdma_set(void __iomem *base, u32 offset, u32 set)
>  
>  /**
>   * xilinx_dpdma_sw_desc_set_dma_addrs - Set DMA addresses in the descriptor
> + * @xdev: DPDMA device
>   * @sw_desc: The software descriptor in which to set DMA addresses
>   * @prev: The previous descriptor
>   * @dma_addr: array of dma addresses
diff mbox series

Patch

diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index 8e602378f2dc..430f3714f6a3 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -295,6 +295,7 @@  static inline void dpdma_set(void __iomem *base, u32 offset, u32 set)
 
 /**
  * xilinx_dpdma_sw_desc_set_dma_addrs - Set DMA addresses in the descriptor
+ * @xdev: DPDMA device
  * @sw_desc: The software descriptor in which to set DMA addresses
  * @prev: The previous descriptor
  * @dma_addr: array of dma addresses