| Message ID | 20210121055641.6307-13-jee.heng.sia@intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: dw-axi-dmac: support Intel KeemBay AxiDMA | expand |
Hi Sia,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on 9791581c049c10929e97098374dd1716a81fefcc]
url: https://github.com/0day-ci/linux/commits/Sia-Jee-Heng/dmaengine-dw-axi-dmac-support-Intel-KeemBay-AxiDMA/20210121-143156
base: 9791581c049c10929e97098374dd1716a81fefcc
config: s390-randconfig-r013-20210121 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 22b68440e1647e16b5ee24b924986207173c02d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://github.com/0day-ci/linux/commit/62b1af38b9707f0b5ff771080825f5d2deb9aa39
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sia-Jee-Heng/dmaengine-dw-axi-dmac-support-Intel-KeemBay-AxiDMA/20210121-143156
git checkout 62b1af38b9707f0b5ff771080825f5d2deb9aa39
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
s390x-linux-gnu-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
coherent.c:(.text+0x76): undefined reference to `memunmap'
s390x-linux-gnu-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
coherent.c:(.text+0xd0): undefined reference to `memremap'
s390x-linux-gnu-ld: coherent.c:(.text+0x19e): undefined reference to `memunmap'
s390x-linux-gnu-ld: drivers/phy/ingenic/phy-ingenic-usb.o: in function `ingenic_usb_phy_probe':
phy-ingenic-usb.c:(.text+0x58): undefined reference to `devm_platform_ioremap_resource'
s390x-linux-gnu-ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup':
clk-fixed-mmio.c:(.text+0x24): undefined reference to `of_iomap'
s390x-linux-gnu-ld: clk-fixed-mmio.c:(.text+0x36): undefined reference to `iounmap'
s390x-linux-gnu-ld: drivers/dma/altera-msgdma.o: in function `request_and_map':
altera-msgdma.c:(.text+0x566): undefined reference to `devm_ioremap'
s390x-linux-gnu-ld: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.o: in function `dw_probe':
dw-axi-dmac-platform.c:(.text+0xc4): undefined reference to `devm_ioremap_resource'
>> s390x-linux-gnu-ld: dw-axi-dmac-platform.c:(.text+0xfc): undefined reference to `devm_platform_ioremap_resource'
s390x-linux-gnu-ld: drivers/dma/dw/platform.o: in function `dw_probe':
platform.c:(.text+0x92): undefined reference to `devm_platform_ioremap_resource'
s390x-linux-gnu-ld: drivers/dma/fsl-edma.o: in function `fsl_edma_probe':
fsl-edma.c:(.text+0xce): undefined reference to `devm_ioremap_resource'
s390x-linux-gnu-ld: fsl-edma.c:(.text+0x1aa): undefined reference to `devm_ioremap_resource'
s390x-linux-gnu-ld: drivers/dma/idma64.o: in function `idma64_platform_probe':
idma64.c:(.text+0x72): undefined reference to `devm_ioremap_resource'
s390x-linux-gnu-ld: drivers/soc/litex/litex_soc_ctrl.o: in function `litex_soc_ctrl_probe':
litex_soc_ctrl.c:(.text+0xa8): undefined reference to `devm_platform_ioremap_resource'
s390x-linux-gnu-ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem':
cistpl.c:(.text+0x82): undefined reference to `iounmap'
s390x-linux-gnu-ld: drivers/pcmcia/cistpl.o: in function `set_cis_map':
cistpl.c:(.text+0x3e8): undefined reference to `ioremap'
s390x-linux-gnu-ld: cistpl.c:(.text+0x41e): undefined reference to `iounmap'
s390x-linux-gnu-ld: cistpl.c:(.text+0x44a): undefined reference to `iounmap'
s390x-linux-gnu-ld: cistpl.c:(.text+0x45c): undefined reference to `ioremap'
s390x-linux-gnu-ld: drivers/input/keyboard/omap4-keypad.o: in function `omap4_keypad_probe':
omap4-keypad.c:(.text+0x156): undefined reference to `ioremap'
s390x-linux-gnu-ld: omap4-keypad.c:(.text+0x196): undefined reference to `iounmap'
s390x-linux-gnu-ld: drivers/input/keyboard/omap4-keypad.o: in function `omap4_keypad_remove':
omap4-keypad.c:(.text+0x204): undefined reference to `iounmap'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 830d3de76abd..062d27c61983 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1160,6 +1160,7 @@ static int parse_device_properties(struct axi_dma_chip *chip) static int dw_probe(struct platform_device *pdev) { + struct device_node *node = pdev->dev.of_node; struct axi_dma_chip *chip; struct resource *mem; struct dw_axi_dma *dw; @@ -1192,6 +1193,12 @@ static int dw_probe(struct platform_device *pdev) if (IS_ERR(chip->regs)) return PTR_ERR(chip->regs); + if (of_device_is_compatible(node, "intel,kmb-axi-dma")) { + chip->apb_regs = devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(chip->apb_regs)) + return PTR_ERR(chip->apb_regs); + } + chip->core_clk = devm_clk_get(chip->dev, "core-clk"); if (IS_ERR(chip->core_clk)) return PTR_ERR(chip->core_clk); @@ -1336,6 +1343,7 @@ static const struct dev_pm_ops dw_axi_dma_pm_ops = { static const struct of_device_id dw_dma_of_id_table[] = { { .compatible = "snps,axi-dma-1.01a" }, + { .compatible = "intel,kmb-axi-dma" }, {} }; MODULE_DEVICE_TABLE(of, dw_dma_of_id_table);