| Message ID | 20210522021313.16405-2-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | DMA: several drivers depend on HAS_IOMEM | expand |
On 22.05.21 04:13, Randy Dunlap wrote: > When CONFIG_HAS_IOMEM is not set/enabled, certain iomap() family > functions [including ioremap(), devm_ioremap(), etc.] are not > available. > Drivers that use these functions should depend on HAS_IOMEM so that > they do not cause build errors. > > Repairs this build error: > s390-linux-ld: drivers/dma/altera-msgdma.o: in function `request_and_map': > altera-msgdma.c:(.text+0x14b0): undefined reference to `devm_ioremap' > > Fixes: a85c6f1b2921 ("dmaengine: Add driver for Altera / Intel mSGDMA IP core") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Stefan Roese <sr@denx.de> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: dmaengine@vger.kernel.org Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > drivers/dma/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210521.orig/drivers/dma/Kconfig > +++ linux-next-20210521/drivers/dma/Kconfig > @@ -59,6 +59,7 @@ config DMA_OF > #devices > config ALTERA_MSGDMA > tristate "Altera / Intel mSGDMA Engine" > + depends on HAS_IOMEM > select DMA_ENGINE > help > Enable support for Altera / Intel mSGDMA controller. > Viele Grüße, Stefan
--- linux-next-20210521.orig/drivers/dma/Kconfig +++ linux-next-20210521/drivers/dma/Kconfig @@ -59,6 +59,7 @@ config DMA_OF #devices config ALTERA_MSGDMA tristate "Altera / Intel mSGDMA Engine" + depends on HAS_IOMEM select DMA_ENGINE help Enable support for Altera / Intel mSGDMA controller.
When CONFIG_HAS_IOMEM is not set/enabled, certain iomap() family functions [including ioremap(), devm_ioremap(), etc.] are not available. Drivers that use these functions should depend on HAS_IOMEM so that they do not cause build errors. Repairs this build error: s390-linux-ld: drivers/dma/altera-msgdma.o: in function `request_and_map': altera-msgdma.c:(.text+0x14b0): undefined reference to `devm_ioremap' Fixes: a85c6f1b2921 ("dmaengine: Add driver for Altera / Intel mSGDMA IP core") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Stefan Roese <sr@denx.de> Cc: Vinod Koul <vkoul@kernel.org> Cc: dmaengine@vger.kernel.org --- drivers/dma/Kconfig | 1 + 1 file changed, 1 insertion(+)