diff mbox series

dmaengine: sf-pdma: apply proper spinlock flags in sf_pdma_prep_dma_memcpy()

Message ID 20210611065336.GA1121@raspberrypi (mailing list archive)
State Accepted
Commit 94b4cd7c5fc0dd6858a046b00ca729fb0512b9ba
Headers show
Series dmaengine: sf-pdma: apply proper spinlock flags in sf_pdma_prep_dma_memcpy() | expand

Commit Message

Austin Kim June 11, 2021, 6:53 a.m. UTC 
From: Austin Kim <austin.kim@lge.com>

The second parameter of spinlock_irq[save/restore] function is flags,
which is the last input parameter of sf_pdma_prep_dma_memcpy().

So declare local variable 'iflags' to be used as the second parameter of
spinlock_irq[save/restore] function.

Signed-off-by: Austin Kim <austin.kim@lge.com>
---
 drivers/dma/sf-pdma/sf-pdma.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Vinod Koul June 16, 2021, 10:40 a.m. UTC | #1 
On 11-06-21, 07:53, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
> 
> The second parameter of spinlock_irq[save/restore] function is flags,
> which is the last input parameter of sf_pdma_prep_dma_memcpy().
> 
> So declare local variable 'iflags' to be used as the second parameter of
> spinlock_irq[save/restore] function.

Applied, thanks
Austin Kim June 16, 2021, 10:56 a.m. UTC | #2 
2021년 6월 16일 (수) 오후 7:40, Vinod Koul <vkoul@kernel.org>님이 작성:
>
> On 11-06-21, 07:53, Austin Kim wrote:
> > From: Austin Kim <austin.kim@lge.com>
> >
> > The second parameter of spinlock_irq[save/restore] function is flags,
> > which is the last input parameter of sf_pdma_prep_dma_memcpy().
> >
> > So declare local variable 'iflags' to be used as the second parameter of
> > spinlock_irq[save/restore] function.
>
> Applied, thanks

Great, thanks!

>
> --
> ~Vinod
diff mbox series

Patch

diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index c4c4e8575764..f12606aeff87 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -94,6 +94,7 @@  sf_pdma_prep_dma_memcpy(struct dma_chan *dchan,	dma_addr_t dest, dma_addr_t src,
 {
 	struct sf_pdma_chan *chan = to_sf_pdma_chan(dchan);
 	struct sf_pdma_desc *desc;
+	unsigned long iflags;
 
 	if (chan && (!len || !dest || !src)) {
 		dev_err(chan->pdma->dma_dev.dev,
@@ -109,10 +110,10 @@  sf_pdma_prep_dma_memcpy(struct dma_chan *dchan,	dma_addr_t dest, dma_addr_t src,
 	desc->dirn = DMA_MEM_TO_MEM;
 	desc->async_tx = vchan_tx_prep(&chan->vchan, &desc->vdesc, flags);
 
-	spin_lock_irqsave(&chan->vchan.lock, flags);
+	spin_lock_irqsave(&chan->vchan.lock, iflags);
 	chan->desc = desc;
 	sf_pdma_fill_desc(desc, dest, src, len);
-	spin_unlock_irqrestore(&chan->vchan.lock, flags);
+	spin_unlock_irqrestore(&chan->vchan.lock, iflags);
 
 	return desc->async_tx;
 }