| Message ID | 20210731091939.510816-1-jordy@pwning.systems (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5eea6c9712bd2a707216d7b923090510d60f9663 |
| Headers | show |
| Series | dmaengine: usb-dmac: make usb_dmac_get_current_residue unsigned | expand |
On Sat, Jul 31, 2021 at 11:19:38AM +0200, Jordy Zomer wrote: > The usb_dmac_get_current_residue function used to > take a signed integer as a pos parameter. > The only callers of this function passes an unsigned integer to it. > Therefore to make it obviously safe, let's just make this an unsgined > integer as this is used in pointer arithmetics. > > Signed-off-by: Jordy Zomer <jordy@pwning.systems> > --- > drivers/dma/sh/usb-dmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c > index 8f7ceb698226..a5e225c15730 100644 > --- a/drivers/dma/sh/usb-dmac.c > +++ b/drivers/dma/sh/usb-dmac.c > @@ -466,7 +466,7 @@ static int usb_dmac_chan_terminate_all(struct dma_chan *chan) > > static unsigned int usb_dmac_get_current_residue(struct usb_dmac_chan *chan, > struct usb_dmac_desc *desc, > - int sg_index) > + unsigned int sg_index) > { > struct usb_dmac_sg *sg = desc->sg + sg_index; > u32 mem_addr = sg->mem_addr & 0xffffffff; > -- > 2.27.0 > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On 31-07-21, 11:19, Jordy Zomer wrote: > The usb_dmac_get_current_residue function used to > take a signed integer as a pos parameter. > The only callers of this function passes an unsigned integer to it. > Therefore to make it obviously safe, let's just make this an unsgined > integer as this is used in pointer arithmetics. Applied, thanks
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c index 8f7ceb698226..a5e225c15730 100644 --- a/drivers/dma/sh/usb-dmac.c +++ b/drivers/dma/sh/usb-dmac.c @@ -466,7 +466,7 @@ static int usb_dmac_chan_terminate_all(struct dma_chan *chan) static unsigned int usb_dmac_get_current_residue(struct usb_dmac_chan *chan, struct usb_dmac_desc *desc, - int sg_index) + unsigned int sg_index) { struct usb_dmac_sg *sg = desc->sg + sg_index; u32 mem_addr = sg->mem_addr & 0xffffffff;
The usb_dmac_get_current_residue function used to take a signed integer as a pos parameter. The only callers of this function passes an unsigned integer to it. Therefore to make it obviously safe, let's just make this an unsgined integer as this is used in pointer arithmetics. Signed-off-by: Jordy Zomer <jordy@pwning.systems> --- drivers/dma/sh/usb-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)