| Message ID | 20210802175532.54311-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v1,1/1] dmaengine: acpi: Check for errors from acpi_register_gsi() separately | expand |
On 02-08-21, 20:55, Andy Shevchenko wrote: > While IRQ test agaist the returned variable in practice is a good enough > there is still a room for theoretical mistake in case the vIRQ of the > device contains the same error code that acpi_register_gsi() may return. > Due to this, check for error code separately from matching the vIRQs. > > Besides that, append documentation to tell why acpi_gsi_to_irq() can't > be used and we call acpi_register_gsi() instead. patch fails to apply, pls rebase > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/dma/acpi-dma.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/acpi-dma.c b/drivers/dma/acpi-dma.c > index 52768dc8ce12..5906eae26e2a 100644 > --- a/drivers/dma/acpi-dma.c > +++ b/drivers/dma/acpi-dma.c > @@ -75,8 +75,16 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp, > si->mmio_base_high != upper_32_bits(mem)) > return 0; > > - /* Match device by Linux vIRQ */ > + /* > + * acpi_gsi_to_irq() can't be used because some platforms do not save > + * registered IRQs in the MP table. Instead we just try to register > + * the GSI, which is the core part of the above mentioned function. > + */ > ret = acpi_register_gsi(NULL, si->gsi_interrupt, si->interrupt_mode, si->interrupt_polarity); > + if (ret < 0) > + return 0; > + > + /* Match device by Linux vIRQ */ > if (ret != irq) > return 0; > > -- > 2.30.2
On Fri, Aug 06, 2021 at 07:14:50PM +0530, Vinod Koul wrote: > On 02-08-21, 20:55, Andy Shevchenko wrote: > > While IRQ test agaist the returned variable in practice is a good enough > > there is still a room for theoretical mistake in case the vIRQ of the > > device contains the same error code that acpi_register_gsi() may return. > > Due to this, check for error code separately from matching the vIRQs. > > > > Besides that, append documentation to tell why acpi_gsi_to_irq() can't > > be used and we call acpi_register_gsi() instead. > > patch fails to apply, pls rebase I don't see that you applied the previous patch [1]. Care to apply it, please? [1]: https://lore.kernel.org/dmaengine/20210730202715.24375-1-andriy.shevchenko@linux.intel.com/T/#u
On 06-08-21, 18:29, Andy Shevchenko wrote: > On Fri, Aug 06, 2021 at 07:14:50PM +0530, Vinod Koul wrote: > > On 02-08-21, 20:55, Andy Shevchenko wrote: > > > While IRQ test agaist the returned variable in practice is a good enough > > > there is still a room for theoretical mistake in case the vIRQ of the > > > device contains the same error code that acpi_register_gsi() may return. > > > Due to this, check for error code separately from matching the vIRQs. > > > > > > Besides that, append documentation to tell why acpi_gsi_to_irq() can't > > > be used and we call acpi_register_gsi() instead. > > > > patch fails to apply, pls rebase > > I don't see that you applied the previous patch [1]. > Care to apply it, please? Sorry, somehow that one was pushed to queue but never got applied! Have applied both now > > [1]: https://lore.kernel.org/dmaengine/20210730202715.24375-1-andriy.shevchenko@linux.intel.com/T/#u > > -- > With Best Regards, > Andy Shevchenko >
diff --git a/drivers/dma/acpi-dma.c b/drivers/dma/acpi-dma.c index 52768dc8ce12..5906eae26e2a 100644 --- a/drivers/dma/acpi-dma.c +++ b/drivers/dma/acpi-dma.c @@ -75,8 +75,16 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp, si->mmio_base_high != upper_32_bits(mem)) return 0; - /* Match device by Linux vIRQ */ + /* + * acpi_gsi_to_irq() can't be used because some platforms do not save + * registered IRQs in the MP table. Instead we just try to register + * the GSI, which is the core part of the above mentioned function. + */ ret = acpi_register_gsi(NULL, si->gsi_interrupt, si->interrupt_mode, si->interrupt_polarity); + if (ret < 0) + return 0; + + /* Match device by Linux vIRQ */ if (ret != irq) return 0;
While IRQ test agaist the returned variable in practice is a good enough there is still a room for theoretical mistake in case the vIRQ of the device contains the same error code that acpi_register_gsi() may return. Due to this, check for error code separately from matching the vIRQs. Besides that, append documentation to tell why acpi_gsi_to_irq() can't be used and we call acpi_register_gsi() instead. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/dma/acpi-dma.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)