| Message ID | 20210802175820.3153920-1-nathan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: idxd: Remove unused status variable in irq_process_work_list() | expand |
On 8/2/2021 10:58 AM, Nathan Chancellor wrote: > status is no longer used within this block: > > drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status' > [-Wunused-variable] > u8 status = desc->completion->status & DSA_COMP_STATUS_MASK; > ^ > 1 warning generated. > > Fixes: b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Acked-by: Dave Jiang <dave.jiang@intel.com> Thanks. > --- > drivers/dma/idxd/irq.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c > index 65dc7bbb0a13..91e46ca3a0ad 100644 > --- a/drivers/dma/idxd/irq.c > +++ b/drivers/dma/idxd/irq.c > @@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry, > spin_unlock_irqrestore(&irq_entry->list_lock, flags); > > list_for_each_entry(desc, &flist, list) { > - u8 status = desc->completion->status & DSA_COMP_STATUS_MASK; > - > /* > * Check against the original status as ABORT is software defined > * and 0xff, which DSA_COMP_STATUS_MASK can mask out. > > base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d
On 02-08-21, 10:58, Nathan Chancellor wrote: > status is no longer used within this block: > > drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status' > [-Wunused-variable] > u8 status = desc->completion->status & DSA_COMP_STATUS_MASK; > ^ > 1 warning generated. Applied, thanks
diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c index 65dc7bbb0a13..91e46ca3a0ad 100644 --- a/drivers/dma/idxd/irq.c +++ b/drivers/dma/idxd/irq.c @@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry, spin_unlock_irqrestore(&irq_entry->list_lock, flags); list_for_each_entry(desc, &flist, list) { - u8 status = desc->completion->status & DSA_COMP_STATUS_MASK; - /* * Check against the original status as ABORT is software defined * and 0xff, which DSA_COMP_STATUS_MASK can mask out.
status is no longer used within this block: drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status' [-Wunused-variable] u8 status = desc->completion->status & DSA_COMP_STATUS_MASK; ^ 1 warning generated. Fixes: b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/dma/idxd/irq.c | 2 -- 1 file changed, 2 deletions(-) base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d