Message ID | 20210911070533.3114-1-xiongx18@fudan.edu.cn (mailing list archive) |
---|---|
State | Accepted |
Commit | 9bf9e0b44104d05b21761441227ae566c732ecb9 |
Headers | show |
Series | drivers/dma: fix reference count leaks in mmp_pdma_probe | expand |
On 11-09-21, 15:05, Xin Xiong wrote: > The issue happens in an error handling path. If > of_dma_controller_register() fails, the function simply prints error > messages and returns error code, without decrementing the reference > count of pdev->device incremented earlier by > dma_async_device_register(), which may result in refcount leaks. > > Fix it by invoking dma_async_device_unregister() before returning the > error code. Pls use right subsystem tag, git log will tell u the same. I have fixe dit up while applying
diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index 89f1814ff..a23563cd1 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -1123,6 +1123,7 @@ static int mmp_pdma_probe(struct platform_device *op) mmp_pdma_dma_xlate, pdev); if (ret < 0) { dev_err(&op->dev, "of_dma_controller_register failed\n"); + dma_async_device_unregister(&pdev->device); return ret; } }