diff mbox series

[1/5] dt-bindings: dma: ingenic: Add compatible strings for MDMA and BDMA

Message ID 20211011143652.51976-2-paul@crapouillou.net (mailing list archive)
State Changes Requested
Headers show
Series dmaengine: dma-jz4780: Driver updates | expand

Commit Message

Paul Cercueil Oct. 11, 2021, 2:36 p.m. UTC
The JZ4760 and JZ4760B SoCs have two additional DMA controllers: the
MDMA, which only supports memcpy operations, and the BDMA which is
mostly used for transfer between memories and the BCH controller.
The JZ4770 also features the same BDMA as in the JZ4760B, but does not
seem to have a MDMA.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 .../devicetree/bindings/dma/ingenic,dma.yaml  | 26 ++++++++++++-------
 1 file changed, 17 insertions(+), 9 deletions(-)

Comments

Rob Herring (Arm) Oct. 11, 2021, 11:13 p.m. UTC | #1
On Mon, 11 Oct 2021 16:36:48 +0200, Paul Cercueil wrote:
> The JZ4760 and JZ4760B SoCs have two additional DMA controllers: the
> MDMA, which only supports memcpy operations, and the BDMA which is
> mostly used for transfer between memories and the BCH controller.
> The JZ4770 also features the same BDMA as in the JZ4760B, but does not
> seem to have a MDMA.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  .../devicetree/bindings/dma/ingenic,dma.yaml  | 26 ++++++++++++-------
>  1 file changed, 17 insertions(+), 9 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/dma/ingenic,dma.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/dma/ingenic,dma.yaml:32:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1539355

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Rob Herring (Arm) Oct. 12, 2021, 12:48 a.m. UTC | #2
On Mon, 11 Oct 2021 16:36:48 +0200, Paul Cercueil wrote:
> The JZ4760 and JZ4760B SoCs have two additional DMA controllers: the
> MDMA, which only supports memcpy operations, and the BDMA which is
> mostly used for transfer between memories and the BCH controller.
> The JZ4770 also features the same BDMA as in the JZ4760B, but does not
> seem to have a MDMA.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  .../devicetree/bindings/dma/ingenic,dma.yaml  | 26 ++++++++++++-------
>  1 file changed, 17 insertions(+), 9 deletions(-)
> 

With the indentation fixed:

Reviewed-by: Rob Herring <robh@kernel.org>
Paul Cercueil Oct. 13, 2021, 9:34 p.m. UTC | #3
Hi,

Le lun., oct. 11 2021 at 19:48:44 -0500, Rob Herring <robh@kernel.org> 
a écrit :
> On Mon, 11 Oct 2021 16:36:48 +0200, Paul Cercueil wrote:
>>  The JZ4760 and JZ4760B SoCs have two additional DMA controllers: the
>>  MDMA, which only supports memcpy operations, and the BDMA which is
>>  mostly used for transfer between memories and the BCH controller.
>>  The JZ4770 also features the same BDMA as in the JZ4760B, but does 
>> not
>>  seem to have a MDMA.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>>   .../devicetree/bindings/dma/ingenic,dma.yaml  | 26 
>> ++++++++++++-------
>>   1 file changed, 17 insertions(+), 9 deletions(-)
>> 
> 
> With the indentation fixed:
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks Rob, I'll V2 then.

Could you have a look at patch 2/5 too? It touches the dt-bindings as 
well.

Cheers,
-Paul
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/ingenic,dma.yaml b/Documentation/devicetree/bindings/dma/ingenic,dma.yaml
index ac4d59494fc8..f45fd5235879 100644
--- a/Documentation/devicetree/bindings/dma/ingenic,dma.yaml
+++ b/Documentation/devicetree/bindings/dma/ingenic,dma.yaml
@@ -14,15 +14,23 @@  allOf:
 
 properties:
   compatible:
-    enum:
-      - ingenic,jz4740-dma
-      - ingenic,jz4725b-dma
-      - ingenic,jz4760-dma
-      - ingenic,jz4760b-dma
-      - ingenic,jz4770-dma
-      - ingenic,jz4780-dma
-      - ingenic,x1000-dma
-      - ingenic,x1830-dma
+    oneOf:
+      - enum:
+        - ingenic,jz4740-dma
+        - ingenic,jz4725b-dma
+        - ingenic,jz4760-dma
+        - ingenic,jz4760-bdma
+        - ingenic,jz4760-mdma
+        - ingenic,jz4760b-dma
+        - ingenic,jz4760b-bdma
+        - ingenic,jz4760b-mdma
+        - ingenic,jz4770-dma
+        - ingenic,jz4780-dma
+        - ingenic,x1000-dma
+        - ingenic,x1830-dma
+      - items:
+        - const: ingenic,jz4770-bdma
+        - const: ingenic,jz4760b-bdma
 
   reg:
     items: