| Message ID | 20211021030538.3465287-1-mudongliangabcd@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c5a51fc89c0103c03b8a54cf12dac7d014b3a2bf |
| Headers | show |
| Series | dmaengine: tegra210-adma: fix pm runtime unbalance | expand |
On 21/10/2021 04:05, Dongliang Mu wrote: > The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using > pm_runtime_resume_and_get to replace open coding") forgets to replace > the pm_runtime_get_sync in the tegra_adma_probe, but removes the > pm_runtime_put_noidle. > > Fix this by continuing to replace pm_runtime_get_sync with > pm_runtime_resume_and_get in tegra_adma_probe. > > Fixes: 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding") > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> > --- > drivers/dma/tegra210-adma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c > index b1115a6d1935..d1dff3a29db5 100644 > --- a/drivers/dma/tegra210-adma.c > +++ b/drivers/dma/tegra210-adma.c > @@ -867,7 +867,7 @@ static int tegra_adma_probe(struct platform_device *pdev) > > pm_runtime_enable(&pdev->dev); > > - ret = pm_runtime_get_sync(&pdev->dev); > + ret = pm_runtime_resume_and_get(&pdev->dev); > if (ret < 0) > goto rpm_disable; > > Thanks! Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Jon
On 21-10-21, 11:05, Dongliang Mu wrote: > The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using > pm_runtime_resume_and_get to replace open coding") forgets to replace > the pm_runtime_get_sync in the tegra_adma_probe, but removes the > pm_runtime_put_noidle. > > Fix this by continuing to replace pm_runtime_get_sync with > pm_runtime_resume_and_get in tegra_adma_probe. Applied, thanks
diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c index b1115a6d1935..d1dff3a29db5 100644 --- a/drivers/dma/tegra210-adma.c +++ b/drivers/dma/tegra210-adma.c @@ -867,7 +867,7 @@ static int tegra_adma_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) goto rpm_disable;
The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding") forgets to replace the pm_runtime_get_sync in the tegra_adma_probe, but removes the pm_runtime_put_noidle. Fix this by continuing to replace pm_runtime_get_sync with pm_runtime_resume_and_get in tegra_adma_probe. Fixes: 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding") Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> --- drivers/dma/tegra210-adma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)