diff mbox series

dmaengine: ppc4xx: remove unused variable `rval'

Message ID 20211114060856.239314-1-wangborong@cdjrlc.com (mailing list archive)
State Accepted
Commit 7eafa6eed7f1c6d0d7ed2f90792ab6bce462a750
Headers show
Series dmaengine: ppc4xx: remove unused variable `rval' | expand

Commit Message

Jason Wang Nov. 14, 2021, 6:08 a.m. UTC
The variable used for returning status in
`ppc440spe_adma_dma2rxor_prep_src' function is never changed
and this function just need to return 0. Thus, the `rval' can
be removed and return 0 from `ppc440spe_adma_dma2rxor_prep_src'.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/dma/ppc4xx/adma.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Vinod Koul Nov. 25, 2021, 5:18 a.m. UTC | #1
On 14-11-21, 14:08, Jason Wang wrote:
> The variable used for returning status in
> `ppc440spe_adma_dma2rxor_prep_src' function is never changed
> and this function just need to return 0. Thus, the `rval' can
> be removed and return 0 from `ppc440spe_adma_dma2rxor_prep_src'.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
index e2b5129c5f84..5e46e347e28b 100644
--- a/drivers/dma/ppc4xx/adma.c
+++ b/drivers/dma/ppc4xx/adma.c
@@ -3240,7 +3240,6 @@  static int ppc440spe_adma_dma2rxor_prep_src(
 		struct ppc440spe_rxor *cursor, int index,
 		int src_cnt, u32 addr)
 {
-	int rval = 0;
 	u32 sign;
 	struct ppc440spe_adma_desc_slot *desc = hdesc;
 	int i;
@@ -3348,7 +3347,7 @@  static int ppc440spe_adma_dma2rxor_prep_src(
 		break;
 	}
 
-	return rval;
+	return 0;
 }
 
 /**