| Message ID | 20220706082605.114907-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4348d99efa01fe030eb625495de8b9f3578b5c7d |
| Headers | show |
| Series | [v3] dmaengine: altera-msgdma: Fixed some inconsistent function name descriptions | expand |
On 06.07.22 10:26, Jiapeng Chong wrote: > Inconsistent function names describing msgdma_chan_remove() and > msgdma_dma_remove are modified to msgdma_dev_remove() and msgdma_remove(). > > Remove some warnings found by running scripts/kernel-doc, which is caused > by using 'make W=1'. > > drivers/dma/altera-msgdma.c:927: warning: expecting prototype for msgdma_dma_remove(). Prototype was for msgdma_remove() instead. > drivers/dma/altera-msgdma.c:758: warning: expecting prototype for msgdma_chan_remove(). Prototype was for msgdma_dev_remove() instead. > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > Changes in v3: > -Modified the commit title and message. > > drivers/dma/altera-msgdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c > index 6f56dfd375e3..4153c2edb049 100644 > --- a/drivers/dma/altera-msgdma.c > +++ b/drivers/dma/altera-msgdma.c > @@ -749,7 +749,7 @@ static irqreturn_t msgdma_irq_handler(int irq, void *data) > } > > /** > - * msgdma_chan_remove - Channel remove function > + * msgdma_dev_remove() - Device remove function > * @mdev: Pointer to the Altera mSGDMA device structure > */ > static void msgdma_dev_remove(struct msgdma_device *mdev) > @@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev) > } > > /** > - * msgdma_dma_remove - Driver remove function > + * msgdma_remove() - Driver remove function > * @pdev: Pointer to the platform_device structure > * > * Return: Always '0' Viele Grüße, Stefan Roese
On 06-07-22, 16:26, Jiapeng Chong wrote: > Inconsistent function names describing msgdma_chan_remove() and > msgdma_dma_remove are modified to msgdma_dev_remove() and msgdma_remove(). > > Remove some warnings found by running scripts/kernel-doc, which is caused > by using 'make W=1'. > > drivers/dma/altera-msgdma.c:927: warning: expecting prototype for msgdma_dma_remove(). Prototype was for msgdma_remove() instead. > drivers/dma/altera-msgdma.c:758: warning: expecting prototype for msgdma_chan_remove(). Prototype was for msgdma_dev_remove() instead. Applied, thanks
diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c index 6f56dfd375e3..4153c2edb049 100644 --- a/drivers/dma/altera-msgdma.c +++ b/drivers/dma/altera-msgdma.c @@ -749,7 +749,7 @@ static irqreturn_t msgdma_irq_handler(int irq, void *data) } /** - * msgdma_chan_remove - Channel remove function + * msgdma_dev_remove() - Device remove function * @mdev: Pointer to the Altera mSGDMA device structure */ static void msgdma_dev_remove(struct msgdma_device *mdev) @@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev) } /** - * msgdma_dma_remove - Driver remove function + * msgdma_remove() - Driver remove function * @pdev: Pointer to the platform_device structure * * Return: Always '0'
Inconsistent function names describing msgdma_chan_remove() and msgdma_dma_remove are modified to msgdma_dev_remove() and msgdma_remove(). Remove some warnings found by running scripts/kernel-doc, which is caused by using 'make W=1'. drivers/dma/altera-msgdma.c:927: warning: expecting prototype for msgdma_dma_remove(). Prototype was for msgdma_remove() instead. drivers/dma/altera-msgdma.c:758: warning: expecting prototype for msgdma_chan_remove(). Prototype was for msgdma_dev_remove() instead. Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v3: -Modified the commit title and message. drivers/dma/altera-msgdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)