Message ID | 20220810062532.13425-1-ye.xingchen@zte.com.cn (mailing list archive) |
---|---|
State | Accepted |
Commit | 7d81afd2690400f8fb7d9bec0532624562634766 |
Headers | show |
Series | [linux-next] dmaengine: sf-pdma:Remove the print function dev_err() | expand |
On 10-08-22, 06:25, cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > >From the coccinelle check: > > ./drivers/dma/sf-pdma/sf-pdma.c > Error:line 409 is redundant because platform_get_irq() already prints an > error > > ./drivers/dma/sf-pdma/sf-pdma.c > Error:line 424 is redundant because platform_get_irq() already prints an > error > > So,remove the unnecessary print function dev_err() Applied, thanks
diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c index 4f8b8498c5c6..6b524eb6bcf3 100644 --- a/drivers/dma/sf-pdma/sf-pdma.c +++ b/drivers/dma/sf-pdma/sf-pdma.c @@ -405,10 +405,8 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma) chan = &pdma->chans[i]; irq = platform_get_irq(pdev, i * 2); - if (irq < 0) { - dev_err(&pdev->dev, "ch(%d) Can't get done irq.\n", i); + if (irq < 0) return -EINVAL; - } r = devm_request_irq(&pdev->dev, irq, sf_pdma_done_isr, 0, dev_name(&pdev->dev), (void *)chan); @@ -420,10 +418,8 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma) chan->txirq = irq; irq = platform_get_irq(pdev, (i * 2) + 1); - if (irq < 0) { - dev_err(&pdev->dev, "ch(%d) Can't get err irq.\n", i); + if (irq < 0) return -EINVAL; - } r = devm_request_irq(&pdev->dev, irq, sf_pdma_err_isr, 0, dev_name(&pdev->dev), (void *)chan);