diff mbox series

dmaengine: idxd: Remove unused struct idxd_fault

Message ID 20220927133711.98184-1-yuancan@huawei.com (mailing list archive)
State Superseded
Headers show
Series dmaengine: idxd: Remove unused struct idxd_fault | expand

Commit Message

Yuan Can Sept. 27, 2022, 1:37 p.m. UTC 
After commit 0e96454ca26c("dmaengine: idxd: remove fault processing code"), no
one use struct idxd_fault, so remove it.

Signed-off-by: Yuan Can <yuancan@huawei.com>
---
 drivers/dma/idxd/irq.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Fenghua Yu Sept. 27, 2022, 11:35 p.m. UTC | #1 
Hi, Yuan,

> After commit 0e96454ca26c("dmaengine: idxd: remove fault processing code"),
> no one use struct idxd_fault, so remove it.

How about this commit message?

Since fault processing code has been removed, struct idxd_fault is not used any more and can be removed as well.

Fixes: commit 0e96454ca26c ("dmaengine: idxd: remove fault processing code")

Thanks.

-Fenghua
Yuan Can Sept. 28, 2022, 1:46 a.m. UTC | #2 
在 2022/9/28 7:35, Yu, Fenghua 写道:
> Hi, Yuan,
>
>> After commit 0e96454ca26c("dmaengine: idxd: remove fault processing code"),
>> no one use struct idxd_fault, so remove it.
> How about this commit message?
>
> Since fault processing code has been removed, struct idxd_fault is not used any more and can be removed as well.
>
> Fixes: commit 0e96454ca26c ("dmaengine: idxd: remove fault processing code")

Yes, this commit message seems better, let me resend with that.

thanks for your advice!

Best regards,

Yuan Can
diff mbox series

Patch

diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
index 5b9921475be6..6dc299182933 100644
--- a/drivers/dma/idxd/irq.c
+++ b/drivers/dma/idxd/irq.c
@@ -17,12 +17,6 @@  enum irq_work_type {
 	IRQ_WORK_PROCESS_FAULT,
 };
 
-struct idxd_fault {
-	struct work_struct work;
-	u64 addr;
-	struct idxd_device *idxd;
-};
-
 struct idxd_resubmit {
 	struct work_struct work;
 	struct idxd_desc *desc;