| Message ID | 20221212033514.5831-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5840c8915a2f2becd760ba3a700ee7832d13c53f |
| Headers | show |
| Series | dmaengine: idxd: Remove the unused function set_completion_address() | expand |
On 12/11/2022 8:35 PM, Jiapeng Chong wrote: > The function set_completion_address is defined in the dma.c file, but not > called elsewhere, so remove this unused function. > > drivers/dma/idxd/dma.c:66:20: warning: unused function 'set_completion_address'. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3416 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Acked-by: Dave Jiang <dave.jiang@intel.com> Thanks for the cleanup > --- > drivers/dma/idxd/dma.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c > index e0874cb4721c..eb35ca313684 100644 > --- a/drivers/dma/idxd/dma.c > +++ b/drivers/dma/idxd/dma.c > @@ -63,12 +63,6 @@ static void op_flag_setup(unsigned long flags, u32 *desc_flags) > *desc_flags |= IDXD_OP_FLAG_RCI; > } > > -static inline void set_completion_address(struct idxd_desc *desc, > - u64 *compl_addr) > -{ > - *compl_addr = desc->compl_dma; > -} > - > static inline void idxd_prep_desc_common(struct idxd_wq *wq, > struct dsa_hw_desc *hw, char opcode, > u64 addr_f1, u64 addr_f2, u64 len,
On 12-12-22, 11:35, Jiapeng Chong wrote: > The function set_completion_address is defined in the dma.c file, but not > called elsewhere, so remove this unused function. Applied, thanks
diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c index e0874cb4721c..eb35ca313684 100644 --- a/drivers/dma/idxd/dma.c +++ b/drivers/dma/idxd/dma.c @@ -63,12 +63,6 @@ static void op_flag_setup(unsigned long flags, u32 *desc_flags) *desc_flags |= IDXD_OP_FLAG_RCI; } -static inline void set_completion_address(struct idxd_desc *desc, - u64 *compl_addr) -{ - *compl_addr = desc->compl_dma; -} - static inline void idxd_prep_desc_common(struct idxd_wq *wq, struct dsa_hw_desc *hw, char opcode, u64 addr_f1, u64 addr_f2, u64 len,
The function set_completion_address is defined in the dma.c file, but not called elsewhere, so remove this unused function. drivers/dma/idxd/dma.c:66:20: warning: unused function 'set_completion_address'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3416 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/dma/idxd/dma.c | 6 ------ 1 file changed, 6 deletions(-)