| Message ID | 20230328153535.126223-7-tom.zanussi@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | crypto: Add Intel Analytics Accelerator (IAA) crypto compression driver | expand |
On 3/28/23 8:35 AM, Tom Zanussi wrote: > Add a void * to idxd_wqs for user-defined context data. I wonder if we should add accessor functions like get and set private data for the wq. > > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> > --- > drivers/dma/idxd/idxd.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h > index 719f9f1662ad..e55213b5153e 100644 > --- a/drivers/dma/idxd/idxd.h > +++ b/drivers/dma/idxd/idxd.h > @@ -216,6 +216,8 @@ struct idxd_wq { > u32 max_batch_size; > > char driver_name[WQ_NAME_SIZE + 1]; > + > + void *private_data; > }; > > struct idxd_engine {
On Tue, 2023-03-28 at 09:06 -0700, Dave Jiang wrote: > > > On 3/28/23 8:35 AM, Tom Zanussi wrote: > > Add a void * to idxd_wqs for user-defined context data. > > I wonder if we should add accessor functions like get and set private > data for the wq. > > Yeah, makes sense, will do that in v3. Tom > > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> > > --- > > drivers/dma/idxd/idxd.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h > > index 719f9f1662ad..e55213b5153e 100644 > > --- a/drivers/dma/idxd/idxd.h > > +++ b/drivers/dma/idxd/idxd.h > > @@ -216,6 +216,8 @@ struct idxd_wq { > > u32 max_batch_size; > > > > char driver_name[WQ_NAME_SIZE + 1]; > > + > > + void *private_data; > > }; > > > > struct idxd_engine {
diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h index 719f9f1662ad..e55213b5153e 100644 --- a/drivers/dma/idxd/idxd.h +++ b/drivers/dma/idxd/idxd.h @@ -216,6 +216,8 @@ struct idxd_wq { u32 max_batch_size; char driver_name[WQ_NAME_SIZE + 1]; + + void *private_data; }; struct idxd_engine {
Add a void * to idxd_wqs for user-defined context data. Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> --- drivers/dma/idxd/idxd.h | 2 ++ 1 file changed, 2 insertions(+)