diff mbox series

[1/2] dmaengine: idxd: Modify the dependence of attribute pasid_enabled

Message ID 20230614062706.1743078-1-rex.zhang@intel.com (mailing list archive)
State Accepted
Commit 04589e93537d27cb846e4156e614e5c73601e8ab
Headers show
Series [1/2] dmaengine: idxd: Modify the dependence of attribute pasid_enabled | expand

Commit Message

Rex Zhang June 14, 2023, 6:27 a.m. UTC 
From: Rex Zhang <rex.zhang@intel.com>

Kernel PASID and user PASID are separately enabled. User needs to know the
user PASID enabling status to decide how to use IDXD device in user space.
This is done via the attribute /sys/bus/dsa/devices/dsa0/pasid_enabled.
It's unnecessary for user to know the kernel PASID enabling status because
user won't use the kernel PASID. But instead of showing the user PASID
enabling status, the attribute shows the kernel PASID enabling status. Fix
the issue by showing the user PASID enabling status in the attribute.

Fixes: 42a1b73852c4 ("dmaengine: idxd: Separate user and kernel pasid enabling")
Signed-off-by: Rex Zhang <rex.zhang@intel.com>
Acked-by: Fenghua Yu <fenghua.yu@intel.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vinod Koul July 11, 2023, 4:44 p.m. UTC | #1 
On Wed, 14 Jun 2023 14:27:06 +0800, rex.zhang@intel.com wrote:
> Kernel PASID and user PASID are separately enabled. User needs to know the
> user PASID enabling status to decide how to use IDXD device in user space.
> This is done via the attribute /sys/bus/dsa/devices/dsa0/pasid_enabled.
> It's unnecessary for user to know the kernel PASID enabling status because
> user won't use the kernel PASID. But instead of showing the user PASID
> enabling status, the attribute shows the kernel PASID enabling status. Fix
> the issue by showing the user PASID enabling status in the attribute.
> 
> [...]

Applied, thanks!

[1/2] dmaengine: idxd: Modify the dependence of attribute pasid_enabled
      commit: 04589e93537d27cb846e4156e614e5c73601e8ab

Best regards,
diff mbox series

Patch

diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
index 293739ac5596..b6a0a12412af 100644
--- a/drivers/dma/idxd/sysfs.c
+++ b/drivers/dma/idxd/sysfs.c
@@ -1480,7 +1480,7 @@  static ssize_t pasid_enabled_show(struct device *dev,
 {
 	struct idxd_device *idxd = confdev_to_idxd(dev);
 
-	return sysfs_emit(buf, "%u\n", device_pasid_enabled(idxd));
+	return sysfs_emit(buf, "%u\n", device_user_pasid_enabled(idxd));
 }
 static DEVICE_ATTR_RO(pasid_enabled);