diff mbox series

[-next] dmaengine: ste_dma40: Add missing IRQ check in d40_probe

Message ID 20230724144108.2582917-1-ruanjinjie@huawei.com (mailing list archive)
State Accepted
Commit c05ce6907b3d6e148b70f0bb5eafd61dcef1ddc1
Headers show
Series [-next] dmaengine: ste_dma40: Add missing IRQ check in d40_probe | expand

Commit Message

Jinjie Ruan July 24, 2023, 2:41 p.m. UTC 
From: ruanjinjie <ruanjinjie@huawei.com>

Check for the return value of platform_get_irq(): if no interrupt
is specified, it wouldn't make sense to call request_irq().

Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/dma/ste_dma40.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jinjie Ruan Aug. 4, 2023, 1:13 a.m. UTC | #1 
Ping.

On 2023/7/24 22:41, Ruan Jinjie wrote:
> From: ruanjinjie <ruanjinjie@huawei.com>
> 
> Check for the return value of platform_get_irq(): if no interrupt
> is specified, it wouldn't make sense to call request_irq().
> 
> Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
>  drivers/dma/ste_dma40.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index 825001bde42c..89e82508c133 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -3590,6 +3590,10 @@ static int __init d40_probe(struct platform_device *pdev)
>  	spin_lock_init(&base->lcla_pool.lock);
>  
>  	base->irq = platform_get_irq(pdev, 0);
> +	if (base->irq < 0) {
> +		ret = base->irq;
> +		goto destroy_cache;
> +	}
>  
>  	ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base);
>  	if (ret) {
Linus Walleij Aug. 10, 2023, 8:20 a.m. UTC | #2 
On Mon, Jul 24, 2023 at 8:40 AM Ruan Jinjie <ruanjinjie@huawei.com> wrote:

> From: ruanjinjie <ruanjinjie@huawei.com>
>
> Check for the return value of platform_get_irq(): if no interrupt
> is specified, it wouldn't make sense to call request_irq().
>
> Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Vinod Koul Aug. 21, 2023, 1:51 p.m. UTC | #3 
On Mon, 24 Jul 2023 14:41:08 +0000, Ruan Jinjie wrote:
> Check for the return value of platform_get_irq(): if no interrupt
> is specified, it wouldn't make sense to call request_irq().
> 
> 

Applied, thanks!

[1/1] dmaengine: ste_dma40: Add missing IRQ check in d40_probe
      commit: c05ce6907b3d6e148b70f0bb5eafd61dcef1ddc1

Best regards,
diff mbox series

Patch

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 825001bde42c..89e82508c133 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3590,6 +3590,10 @@  static int __init d40_probe(struct platform_device *pdev)
 	spin_lock_init(&base->lcla_pool.lock);
 
 	base->irq = platform_get_irq(pdev, 0);
+	if (base->irq < 0) {
+		ret = base->irq;
+		goto destroy_cache;
+	}
 
 	ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base);
 	if (ret) {