| Message ID | 20230901071115.1322000-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 88ba97688a03843755803bfc28b975ae27d533d1 |
| Headers | show |
| Series | [-next] dmaengine: fsl-edma: Remove redundant dev_err() for platform_get_irq() | expand |
On Fri, 01 Sep 2023 15:11:14 +0800, Jinjie Ruan wrote: > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message > to platform_get_irq*()") and commit 2043727c2882 ("driver core: > platform: Make use of the helper function dev_err_probe()"), there is > no need to call the dev_err() function directly to print a custom > message when handling an error from platform_get_irq() function as it is > going to display an appropriate error message in case of a failure. > > [...] Applied, thanks! [1/1] dmaengine: fsl-edma: Remove redundant dev_err() for platform_get_irq() commit: 88ba97688a03843755803bfc28b975ae27d533d1 Best regards,
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c index 63d48d046f04..d493dddd55b1 100644 --- a/drivers/dma/fsl-edma-main.c +++ b/drivers/dma/fsl-edma-main.c @@ -230,10 +230,8 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi /* request channel irq */ fsl_chan->txirq = platform_get_irq(pdev, i); - if (fsl_chan->txirq < 0) { - dev_err(&pdev->dev, "Can't get chan %d's irq.\n", i); + if (fsl_chan->txirq < 0) return -EINVAL; - } ret = devm_request_irq(&pdev->dev, fsl_chan->txirq, fsl_edma3_tx_handler, IRQF_SHARED,
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") and commit 2043727c2882 ("driver core: platform: Make use of the helper function dev_err_probe()"), there is no need to call the dev_err() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Fixes: 72f5801a4e2b ("dmaengine: fsl-edma: integrate v3 support") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/dma/fsl-edma-main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)