| Message ID | 20230922095039.74878-3-shravan.chippa@microchip.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dma: sf-pdma: various sf-pdma updates for the mpfs platform | expand |
Hey Shravan, On Fri, Sep 22, 2023 at 03:20:38PM +0530, shravan chippa wrote: > From: Shravan Chippa <shravan.chippa@microchip.com> > > add new compatible name microchip,mpfs-pdma to support out of order dma > transfers this will improve the dma throughput for mem-to-mem transfer > > Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> I would appreciate if you would drop any vendor tree related tags when submitting patches upstream, especially for dt-bindings where it actually means something to have my R-b on them. Cheers, Conor. > --- > .../bindings/dma/sifive,fu540-c000-pdma.yaml | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > index a1af0b906365..974467c4bacb 100644 > --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > @@ -27,10 +27,14 @@ allOf: > > properties: > compatible: > - items: > - - enum: > - - sifive,fu540-c000-pdma > - - const: sifive,pdma0 > + oneOf: > + - items: > + - const: microchip,mpfs-pdma # Microchip out of order DMA transfer > + - const: sifive,fu540-c000-pdma # Sifive in-order DMA transfer > + - items: > + - enum: > + - sifive,fu540-c000-pdma > + - const: sifive,pdma0 > description: > Should be "sifive,<chip>-pdma" and "sifive,pdma<version>". > Supported compatible strings are - > -- > 2.34.1 >
Me again, On Fri, Sep 22, 2023 at 10:59:52AM +0100, Conor Dooley wrote: > On Fri, Sep 22, 2023 at 03:20:38PM +0530, shravan chippa wrote: > > From: Shravan Chippa <shravan.chippa@microchip.com> > > > > add new compatible name microchip,mpfs-pdma to support out of order dma > > transfers this will improve the dma throughput for mem-to-mem transfer > > > > Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com> > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > I would appreciate if you would drop any vendor tree related tags when > submitting patches upstream, especially for dt-bindings where it > actually means something to have my R-b on them. > > --- > > .../bindings/dma/sifive,fu540-c000-pdma.yaml | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > index a1af0b906365..974467c4bacb 100644 > > --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > @@ -27,10 +27,14 @@ allOf: > > > > properties: > > compatible: > > - items: > > - - enum: > > - - sifive,fu540-c000-pdma > > - - const: sifive,pdma0 > > + oneOf: > > + - items: > > + - const: microchip,mpfs-pdma # Microchip out of order DMA transfer > > + - const: sifive,fu540-c000-pdma # Sifive in-order DMA transfer Whoops, I meant to say - I'm okay with the soc-specific compatible being added (we should have done that from the start), but I think the comments here about software behaviour should be removed. With that, you can re-add Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > + - items: > > + - enum: > > + - sifive,fu540-c000-pdma > > + - const: sifive,pdma0 > > description: > > Should be "sifive,<chip>-pdma" and "sifive,pdma<version>". > > Supported compatible strings are - > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml index a1af0b906365..974467c4bacb 100644 --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml @@ -27,10 +27,14 @@ allOf: properties: compatible: - items: - - enum: - - sifive,fu540-c000-pdma - - const: sifive,pdma0 + oneOf: + - items: + - const: microchip,mpfs-pdma # Microchip out of order DMA transfer + - const: sifive,fu540-c000-pdma # Sifive in-order DMA transfer + - items: + - enum: + - sifive,fu540-c000-pdma + - const: sifive,pdma0 description: Should be "sifive,<chip>-pdma" and "sifive,pdma<version>". Supported compatible strings are -