| Message ID | 20230924002347.1117757-1-fenghua.yu@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 555921feb2ac03d88647ccc62015e68f157c30a2 |
| Headers | show |
| Series | dmaengine: idxd: rate limit printk in misc interrupt thread | expand |
On 9/23/2023 7:23 PM, Fenghua Yu wrote: > From: Dave Jiang <dave.jiang@intel.com> > > Add rate limit to the dev_warn() call in the misc interrupt thread. This > limits dmesg getting spammed if a descriptor submitter is spamming bad > descriptors with invalid completion records and resulting the errors being > continuously reported by the misc interrupt handling thread. > > Reported-by: Sanjay Kumar <sanjay.k.kumar@intel.com> > Signed-off-by: Dave Jiang <dave.jiang@intel.com> > Reviewed-by: Fenghua Yu <fenghua.yu@intel.com> > --- Acked-by: Lijun Pan <lijun.pan@intel.com> > > This patch was sent to dmaengine mailing list before: > https://lore.kernel.org/all/165125377735.312075.15715853788802098990.stgit@djiang5-desk3.ch.intel.com/ > But it hasn't be merged into upstream yet. Add my Reviewed-by tag > and re-send it. No code or commit message change. > > drivers/dma/idxd/irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c > index 041be6a4dec4..8e895a1e1881 100644 > --- a/drivers/dma/idxd/irq.c > +++ b/drivers/dma/idxd/irq.c > @@ -430,8 +430,8 @@ irqreturn_t idxd_misc_thread(int vec, void *data) > val |= IDXD_INTC_ERR; > > for (i = 0; i < 4; i++) > - dev_warn(dev, "err[%d]: %#16.16llx\n", > - i, idxd->sw_err.bits[i]); > + dev_warn_ratelimited(dev, "err[%d]: %#16.16llx\n", > + i, idxd->sw_err.bits[i]); > err = true; > } >
On Sat, 23 Sep 2023 17:23:47 -0700, Fenghua Yu wrote: > Add rate limit to the dev_warn() call in the misc interrupt thread. This > limits dmesg getting spammed if a descriptor submitter is spamming bad > descriptors with invalid completion records and resulting the errors being > continuously reported by the misc interrupt handling thread. > > Applied, thanks! [1/1] dmaengine: idxd: rate limit printk in misc interrupt thread commit: 555921feb2ac03d88647ccc62015e68f157c30a2 Best regards,
diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c index 041be6a4dec4..8e895a1e1881 100644 --- a/drivers/dma/idxd/irq.c +++ b/drivers/dma/idxd/irq.c @@ -430,8 +430,8 @@ irqreturn_t idxd_misc_thread(int vec, void *data) val |= IDXD_INTC_ERR; for (i = 0; i < 4; i++) - dev_warn(dev, "err[%d]: %#16.16llx\n", - i, idxd->sw_err.bits[i]); + dev_warn_ratelimited(dev, "err[%d]: %#16.16llx\n", + i, idxd->sw_err.bits[i]); err = true; }