| Message ID | 20231014211656.1512016-2-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c1939c2f76d7971b0a02cad0d1d1e9d44ac37cfc |
| Headers | show |
| Series | dmaengine: xilinx: xilinx_dma: Fix kernel doc about xilinx_dma_remove() | expand |
On Sat, 14 Oct 2023 23:16:57 +0200, Uwe Kleine-König wrote: > Since commit cc99582d46b4 ("dmaengine: xilinx: xilinx_dma: Convert to > platform remove callback returning void") xilinx_dma_remove() doesn't > return zero any more. As the function has no return value any more, just > drop the statement about the return value. > > Applied, thanks! [1/1] dmaengine: xilinx: xilinx_dma: Fix kernel doc about xilinx_dma_remove() commit: c1939c2f76d7971b0a02cad0d1d1e9d44ac37cfc Best regards,
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 0c363a1ed853..e40696f6f864 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -3242,8 +3242,6 @@ static int xilinx_dma_probe(struct platform_device *pdev) /** * xilinx_dma_remove - Driver remove function * @pdev: Pointer to the platform_device structure - * - * Return: Always '0' */ static void xilinx_dma_remove(struct platform_device *pdev) {
Since commit cc99582d46b4 ("dmaengine: xilinx: xilinx_dma: Convert to platform remove callback returning void") xilinx_dma_remove() doesn't return zero any more. As the function has no return value any more, just drop the statement about the return value. Reported-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, the wrong kernel doc comment was pointed out by Radhey Shyam Pandey during review of the patch that became cc99582d46b4. Vinod Koul still picked up the patch unmodified and asked for a follow up patch (https://lore.kernel.org/all/ZRUvjz7oO6iK1HTm@matsya). Here it is. Best regards Uwe drivers/dma/xilinx/xilinx_dma.c | 2 -- 1 file changed, 2 deletions(-) base-commit: cc99582d46b428ba4c2cb7ecd05df4569b02d1f4