| Message ID | 20231026072549.103102-3-guomengqi3@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add dma controller driver for HiSilicon Ascend310/910 | expand |
On Thu, 26 Oct 2023 15:25:49 +0800, Guo Mengqi wrote: > Add device-tree binding documentation for sdma hardware on > HiSilicon Ascend SoC families. > > Signed-off-by: Guo Mengqi <guomengqi3@huawei.com> > --- > .../bindings/dma/hisilicon,ascend-sdma.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml: dma-can-stall: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231026072549.103102-3-guomengqi3@huawei.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Oct 26, 2023 at 03:25:49PM +0800, Guo Mengqi wrote: > Add device-tree binding documentation for sdma hardware on > HiSilicon Ascend SoC families. > > Signed-off-by: Guo Mengqi <guomengqi3@huawei.com> > --- This is where you explain any expected failure. Resending the same patch with the same failure again is not a great strategy. The patch needs to stand on its own and not rely on some explanation in a prior version. > .../bindings/dma/hisilicon,ascend-sdma.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml Reviewed-by: Rob Herring <robh@kernel.org> I had missed that pasid-num-bits and dma-can-stall are IOMMU consumer properties. (We really should have prefixed them with 'iommu'.) I've now added them to dtschema which should fix the warning. Rob
在 2023/10/27 0:55, Rob Herring 写道: > On Thu, Oct 26, 2023 at 03:25:49PM +0800, Guo Mengqi wrote: >> Add device-tree binding documentation for sdma hardware on >> HiSilicon Ascend SoC families. >> >> Signed-off-by: Guo Mengqi <guomengqi3@huawei.com> >> --- > This is where you explain any expected failure. Resending the same patch > with the same failure again is not a great strategy. The patch needs to > stand on its own and not rely on some explanation in a prior version. OK, will do this next time. I was eager to see whether those kernel build warnings are fixed, so sent the new patch quickly. >> .../bindings/dma/hisilicon,ascend-sdma.yaml | 73 +++++++++++++++++++ >> 1 file changed, 73 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml > Reviewed-by: Rob Herring <robh@kernel.org> > > I had missed that pasid-num-bits and dma-can-stall are IOMMU consumer > properties. (We really should have prefixed them with 'iommu'.) I've now > added them to dtschema which should fix the warning. They do look a little confusing. Thanks. -Mengqi > Rob > > .
diff --git a/Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml b/Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml new file mode 100644 index 000000000000..7b452b54fe0c --- /dev/null +++ b/Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/hisilicon,ascend-sdma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HiSilicon Ascend System DMA (SDMA) controller + +description: | + The Ascend SDMA controller is used for transferring data + in system memory. + +maintainers: + - Guo Mengqi <guomengqi3@huawei.com> + +allOf: + - $ref: dma-controller.yaml# + +properties: + compatible: + enum: + - hisilicon,ascend310-sdma + - hisilicon,ascend910-sdma + + reg: + maxItems: 1 + + '#dma-cells': + const: 1 + description: + Clients specify a single cell with channel number. + + dma-channel-mask: + minItems: 1 + maxItems: 2 + + iommus: + maxItems: 1 + + pasid-num-bits: + description: | + This tells smmu that this device supports iommu-sva feature. + This determines the maximum number of digits in the pasid. + maximum: 0x10 + + dma-coherent: true + + dma-can-stall: true + +required: + - compatible + - reg + - dma-channel-mask + - '#dma-cells' + - iommus + - pasid-num-bits + +additionalProperties: false + +examples: + - | + dma-controller@880e0000 { + compatible = "hisilicon,ascend310-sdma"; + reg = <0x880e0000 0x10000>; + dma-channel-mask = <0xff00>; + iommus = <&smmu 0x7f46>; + pasid-num-bits = <0x10>; + dma-coherent; + dma-can-stall; + #dma-cells = <1>; + }; + +...
Add device-tree binding documentation for sdma hardware on HiSilicon Ascend SoC families. Signed-off-by: Guo Mengqi <guomengqi3@huawei.com> --- .../bindings/dma/hisilicon,ascend-sdma.yaml | 73 +++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml